411198: [regression] Patch Set operations failing
•Don't release patch set details aggressively
Change-Id: Id484851dac0bf4d2a0e4a7c2da05fdbc30198fcc
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=411198
diff --git a/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/remote/PatchSetContentIdRemoteFactory.java b/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/remote/PatchSetContentIdRemoteFactory.java
index 19336a6..4473d8b 100644
--- a/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/remote/PatchSetContentIdRemoteFactory.java
+++ b/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/remote/PatchSetContentIdRemoteFactory.java
@@ -43,7 +43,6 @@
itemSetConsumer.pull(false, monitor);
detail = itemSetConsumer.getRemoteObject();
}
- itemSetConsumer.release();
if (detail != null) {
PatchSetContent content = new PatchSetContent((PatchSet) null, detail);
return pull(parentObject, content, monitor);
diff --git a/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/factories/AbstractPatchSetUiFactory.java b/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/factories/AbstractPatchSetUiFactory.java
index f9fcd2f..591202e 100644
--- a/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/factories/AbstractPatchSetUiFactory.java
+++ b/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/factories/AbstractPatchSetUiFactory.java
@@ -57,7 +57,6 @@
RemoteEmfConsumer<IReview, IReviewItemSet, String, PatchSetDetail, PatchSetDetail, String> consumer = getGerritFactoryProvider().getReviewItemSetFactory()
.getConsumerForModel(getModelObject().getReview(), set);
PatchSetDetail remoteObject = consumer.getRemoteObject();
- consumer.release();
return remoteObject;
}