| commit | 798fe277b8fdc0e4c97076dab8a0c43fef99c08f | [log] [tgz] |
|---|---|---|
| author | Carsten Hammer <carsten.hammer@t-online.de> | Sat Sep 12 14:05:17 2020 +0200 |
| committer | Carsten Hammer <carsten.hammer@t-online.de> | Wed Sep 23 12:12:40 2020 -0400 |
| tree | 5140342fbc29d111b93a4ad716feed8e23c69f3e | |
| parent | 5b4b83e46740d27c809c47f33b611cc99793951b [diff] |
Bug 567294 - Check for sign of bitwise operation involving 0x7ffffffc (2147483644) in new org.eclipse.pde.api.tools.internal.builder.ReferenceExtractor(IApiType, Set, int) This method compares a bitwise expression such as ((val & CONSTANT) > 0) where CONSTANT is the negative number. Using bit arithmetic and then comparing with the greater than operator can lead to unexpected results. This comparison is unlikely to work as expected. The good practice is to use '!= 0' instead of '> 0'. Rank: Scary (5), confidence: High Pattern: BIT_SIGNED_CHECK_HIGH_BIT Type: BIT, Category: CORRECTNESS (Correctness) Change-Id: I137fdf5298d6ef23cb3c3128042aed11fd6cad89 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Thanks for your interest in this project.
The PDE project the Eclipse tooling to develop plug-ins and OSGI bundles.
Website: https://www.eclipse.org/pde/
Contributions to PDE are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.
Information regarding source code management, builds, coding standards, and more.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!
Contact the project developers via the project's “dev” list.