Convert to StringBuilder
There is no point in using StringBuffer which synchronizes by default.
Change-Id: I8a07f6bcb7969ef770007a3213537737c31429a1
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
diff --git a/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/PlatformStatus.java b/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/PlatformStatus.java
index 512b7cd..55b246b 100644
--- a/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/PlatformStatus.java
+++ b/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/PlatformStatus.java
@@ -82,7 +82,7 @@
@Override
public String toString() {
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
buffer.append("PlatformStatus(");
buffer.append("id=" + id);
buffer.append(", name=" + name);
diff --git a/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/TestResultsGenerator.java b/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/TestResultsGenerator.java
index fb04c89..8fe67db 100644
--- a/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/TestResultsGenerator.java
+++ b/bundles/org.eclipse.build.tools/src/org/eclipse/releng/generators/TestResultsGenerator.java
@@ -548,7 +548,7 @@
}
private void formatAccessesErrorRow(final String fileName, final int forbiddenAccessesWarningsCount,
- final int discouragedAccessesWarningsCount, final int infoCount, final StringBuffer buffer) {
+ final int discouragedAccessesWarningsCount, final int infoCount, final StringBuilder buffer) {
if ((forbiddenAccessesWarningsCount == 0) && (discouragedAccessesWarningsCount == 0) && (infoCount == 0)) {
return;
@@ -609,7 +609,7 @@
}
private void formatCompileErrorRow(final String fileName, final int errorCount, final int warningCount,
- final StringBuffer buffer) {
+ final StringBuilder buffer) {
if ((errorCount == 0) && (warningCount == 0)) {
return;
@@ -737,7 +737,7 @@
return isBuildTested;
}
- private void parseCompileLog(final String log, final StringBuffer compilerLog, final StringBuffer accessesLog) {
+ private void parseCompileLog(final String log, final StringBuilder compilerLog, final StringBuilder accessesLog) {
int errorCount = 0;
int warningCount = 0;
int forbiddenWarningCount = 0;
@@ -803,7 +803,7 @@
// use wildcard in place of version number on directory names
// log(log + "/n");
String logName = log.substring(getCompileLogsDirectoryName().length() + 1);
- final StringBuffer buffer = new StringBuffer(logName);
+ final StringBuilder buffer = new StringBuilder(logName);
buffer.replace(logName.indexOf("_") + 1, logName.indexOf(File.separator, logName.indexOf("_") + 1), "*");
logName = new String(buffer);
@@ -832,8 +832,8 @@
}
log("DEBUG: BEGIN: Parsing compile logs and generating summary table.");
String compileLogResults = "";
- final StringBuffer compilerString = new StringBuffer();
- final StringBuffer accessesString = new StringBuffer();
+ final StringBuilder compilerString = new StringBuilder();
+ final StringBuilder accessesString = new StringBuilder();
processCompileLogsDirectory(getCompileLogsDirectoryName(), compilerString, accessesString);
if (compilerString.length() == 0) {
compilerString.append(
@@ -1115,8 +1115,8 @@
}
}
- private void processCompileLogsDirectory(final String directoryName, final StringBuffer compilerLog,
- final StringBuffer accessesLog) {
+ private void processCompileLogsDirectory(final String directoryName, final StringBuilder compilerLog,
+ final StringBuilder accessesLog) {
final File sourceDirectory = new File(directoryName);
if (sourceDirectory.isFile()) {
if (sourceDirectory.getName().endsWith(".log")) {
@@ -1183,7 +1183,7 @@
return result;
}
- private void readCompileLog(final String log, final StringBuffer compilerLog, final StringBuffer accessesLog) {
+ private void readCompileLog(final String log, final StringBuilder compilerLog, final StringBuilder accessesLog) {
final String fileContents = readFile(log);
final int errorCount = countCompileErrors(fileContents);
@@ -1194,9 +1194,9 @@
if (errorCount != 0) {
// use wildcard in place of version number on directory names
String logName = log.substring(getCompileLogsDirectoryName().length() + 1);
- final StringBuffer stringBuffer = new StringBuffer(logName);
- stringBuffer.replace(logName.indexOf("_") + 1, logName.indexOf(File.separator, logName.indexOf("_") + 1), "*");
- logName = new String(stringBuffer);
+ final StringBuilder stringBuilder = new StringBuilder(logName);
+ stringBuilder.replace(logName.indexOf("_") + 1, logName.indexOf(File.separator, logName.indexOf("_") + 1), "*");
+ logName = new String(stringBuilder);
anErrorTracker.registerError(logName);
}
diff --git a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/AbstractDOMConverter.java b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/AbstractDOMConverter.java
index 361a1a7..b64f9a7 100644
--- a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/AbstractDOMConverter.java
+++ b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/AbstractDOMConverter.java
@@ -39,7 +39,7 @@
protected Messages messages;
private String convertToHTML(final String s) {
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
for (int i = 0, max = s.length(); i < max; i++) {
final char c = s.charAt(i);
switch (c) {
diff --git a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/DOMTxtConverter.java b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/DOMTxtConverter.java
index 313466c..aef152e 100644
--- a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/DOMTxtConverter.java
+++ b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/DOMTxtConverter.java
@@ -22,7 +22,7 @@
@Override
public String getUnderLine(final String sourceBefore, final String sourceOfError) {
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
char[] chars = sourceBefore.toCharArray();
for (int i = 0, max = chars.length; i < max; i++) {
switch (chars[i]) {
diff --git a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemNode.java b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemNode.java
index 3a0655b..1a88736 100644
--- a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemNode.java
+++ b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemNode.java
@@ -57,7 +57,7 @@
@Override
public String toString() {
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
switch (severityType) {
case ERROR :
buffer.append("ERROR ");//$NON-NLS-1$
diff --git a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemSummaryNode.java b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemSummaryNode.java
index 2072cc7..e54b2e9 100644
--- a/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemSummaryNode.java
+++ b/bundles/org.eclipse.releng.build.tools.convert/src/org/eclipse/releng/build/tools/convert/dom/ProblemSummaryNode.java
@@ -18,7 +18,7 @@
@Override
public String toString() {
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
buffer.append("problems : ") //$NON-NLS-1$
.append(numberOfProblems).append(" errors : ") //$NON-NLS-1$
.append(numberOfErrors).append(" warnings : ") //$NON-NLS-1$
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/AbstractResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/AbstractResults.java
index 1db3c0d..2aa4b4a 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/AbstractResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/AbstractResults.java
@@ -215,11 +215,11 @@
void printGlobalTime(long start, String end) {
long time = System.currentTimeMillis();
String resultsName = getName();
- StringBuffer buffer;
+ StringBuilder buffer;
if (resultsName == null) {
- buffer = new StringBuffer(" => time spent was "); //$NON-NLS-1$
+ buffer = new StringBuilder(" => time spent was "); //$NON-NLS-1$
} else {
- buffer = new StringBuffer(" => time spent in '"); //$NON-NLS-1$
+ buffer = new StringBuilder(" => time spent in '"); //$NON-NLS-1$
buffer.append(resultsName);
buffer.append("' was "); //$NON-NLS-1$
}
@@ -246,7 +246,7 @@
}
}
-void println(StringBuffer buffer) {
+void println(StringBuilder buffer) {
println(buffer.toString());
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/BuildResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/BuildResults.java
index 502d3b1..62bb7f2 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/BuildResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/BuildResults.java
@@ -522,7 +522,7 @@
@Override
public String toString() {
- StringBuffer buffer = new StringBuffer(this.name);
+ StringBuilder buffer = new StringBuilder(this.name);
buffer.append(": "); //$NON-NLS-1$
int length = this.dimensions.length;
for (int i = 0; i < length; i++) {
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ComponentResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ComponentResults.java
index 447c0eb..c4d792a 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ComponentResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ComponentResults.java
@@ -325,7 +325,7 @@
// manage monitor
int size = scenarios.size();
subMonitor.setWorkRemaining(size+1);
- StringBuffer buffer = new StringBuffer("Component "); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder("Component "); //$NON-NLS-1$
buffer.append(this.name);
buffer.append("..."); //$NON-NLS-1$
String title = buffer.toString();
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ConfigResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ConfigResults.java
index 5d3606f..6759ec4 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ConfigResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ConfigResults.java
@@ -526,7 +526,7 @@
// Set the failure on the current build if necessary
int failure_threshold = getPerformance().failure_threshold;
if (this.delta >= (failure_threshold/100.0)) {
- StringBuffer buffer = new StringBuffer("Performance criteria not met when compared to '"); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder("Performance criteria not met when compared to '"); //$NON-NLS-1$
buffer.append(this.baseline.getName());
buffer.append("': "); //$NON-NLS-1$
buffer.append(DB_Results.getDefaultDimension().getName());
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/DB_Results.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/DB_Results.java
index 77e05b7..37584ce 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/DB_Results.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/DB_Results.java
@@ -292,7 +292,7 @@
static class LogWriter extends PrintWriter {
long[] starts = new long[10];
long[] times = new long[10];
- StringBuffer[] buffers = new StringBuffer[10];
+ StringBuilder[] buffers = new StringBuilder[10];
int depth = -1, max = -1;
public LogWriter() {
super(LOG_STR_WRITER);
@@ -300,10 +300,10 @@
void starts(String log) {
if (++this.depth >= this.buffers.length) {
System.arraycopy(this.times, 0, this.times = new long[this.depth+10], 0, this.depth);
- System.arraycopy(this.buffers, 0, this.buffers= new StringBuffer[this.depth+10], 0, this.depth);
+ System.arraycopy(this.buffers, 0, this.buffers= new StringBuilder[this.depth+10], 0, this.depth);
}
- StringBuffer buffer = this.buffers[this.depth];
- if (this.buffers[this.depth] == null) buffer = this.buffers[this.depth] = new StringBuffer();
+ StringBuilder buffer = this.buffers[this.depth];
+ if (this.buffers[this.depth] == null) buffer = this.buffers[this.depth] = new StringBuilder();
buffer.append(log);
this.starts[this.depth] = System.currentTimeMillis();
if (this.depth > this.max) this.max = this.depth;
@@ -326,7 +326,7 @@
this.depth = this.max = -1;
this.starts = new long[10];
this.times = new long[10];
- this.buffers = new StringBuffer[10];
+ this.buffers = new StringBuilder[10];
}
@Override
public String toString() {
@@ -463,7 +463,7 @@
}
}
StringTokenizer tokenizer = new StringTokenizer(scenarioName, ".");
- StringBuffer buffer = new StringBuffer(tokenizer.nextToken());
+ StringBuilder buffer = new StringBuilder(tokenizer.nextToken());
if (tokenizer.hasMoreTokens()) {
buffer.append('.');
buffer.append(tokenizer.nextToken());
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/PerformanceResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/PerformanceResults.java
index af43fa2..e4fe7b0 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/PerformanceResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/PerformanceResults.java
@@ -74,7 +74,7 @@
this.start = start;
}
String display() {
- StringBuffer buffer = new StringBuffer(" [elapsed: "); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder(" [elapsed: "); //$NON-NLS-1$
long elapsed = getElapsed();
buffer.append(Util.timeChrono(elapsed));
if (this.count > 0) {
@@ -233,13 +233,13 @@
int refLength = this.configPattern.length();
for (int i=1; i<length; i++) {
String config = this.sortedConfigNames[i];
- StringBuffer newConfig = null;
+ StringBuilder newConfig = null;
if (refLength != config.length()) return null; // strings have not the same length => cannot find a pattern
for (int j=0; j<refLength; j++) {
char c = this.configPattern.charAt(j);
if (config.charAt(j) != c) {
if (newConfig == null) {
- newConfig = new StringBuffer(refLength);
+ newConfig = new StringBuilder(refLength);
if (j == 0) return null; // first char is already different => cannot find a pattern
newConfig.append(this.configPattern.substring(0, j));
}
@@ -399,14 +399,14 @@
// Manage monitor
int percentage = (int) ((((double)(i+1)) / (componentsLength+1)) * 100);
- StringBuffer tnBuffer= taskName==null ? new StringBuffer() : new StringBuffer(taskName);
+ StringBuilder tnBuffer= taskName==null ? new StringBuilder() : new StringBuilder(taskName);
tnBuffer.append(" ("); //$NON-NLS-1$
if (buildName != null) {
tnBuffer.append(buildName).append(": "); //$NON-NLS-1$
}
tnBuffer.append(percentage).append("%)"); //$NON-NLS-1$
subMonitor.setTaskName(tnBuffer.toString());
- StringBuffer subTaskBuffer = new StringBuffer("Component "); //$NON-NLS-1$
+ StringBuilder subTaskBuffer = new StringBuilder("Component "); //$NON-NLS-1$
subTaskBuffer.append(componentName);
subTaskBuffer.append("..."); //$NON-NLS-1$
subMonitor.subTask(subTaskBuffer.toString());
@@ -850,7 +850,7 @@
public String[] updateBuilds(String[] builds, boolean force, File dataDir, IProgressMonitor monitor) {
// Print title
- StringBuffer buffer = new StringBuffer("Update data for "); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder("Update data for "); //$NON-NLS-1$
int length = builds == null ? 0 : builds.length;
switch (length) {
case 0:
@@ -897,7 +897,7 @@
public String[] updateBuild(String buildName, boolean force, File dataDir, IProgressMonitor monitor) {
// Print title
- StringBuffer buffer = new StringBuffer("Update data for "); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder("Update data for "); //$NON-NLS-1$
if (buildName == null) {
buffer.append("all builds"); //$NON-NLS-1$
reset(dataDir);
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/SQL_Results.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/SQL_Results.java
index 26ab852..bc8dad7 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/SQL_Results.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/SQL_Results.java
@@ -142,7 +142,7 @@
*/
ResultSet queryDimScalars(int datapointId) throws SQLException {
if (this.queryDimScalars == null) {
- StringBuffer buffer = new StringBuffer("select DIM_ID, VALUE from SCALAR where "); //$NON-NLS-1$
+ StringBuilder buffer = new StringBuilder("select DIM_ID, VALUE from SCALAR where "); //$NON-NLS-1$
buffer.append("DATAPOINT_ID = ? and "); //$NON-NLS-1$
Dim[] dimensions = DB_Results.getResultsDimensions();
int length = dimensions.length;
@@ -266,7 +266,7 @@
if (builds == null) {
throw new RuntimeException("builds unexpectedly null at this point. Programming error?");
}
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
loop: for (int idx=0; idx < builds[0].length(); idx++) {
char ch = builds[0].charAt(idx);
for (int i=1; i<length; i++) {
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ScenarioResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ScenarioResults.java
index 52e96c0..4c9a732 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ScenarioResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/db/ScenarioResults.java
@@ -78,7 +78,7 @@
*/
public String getBaselineBuildName() {
int size = size();
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
for (int i=0; i<size; i++) {
ConfigResults configResults = (ConfigResults) this.children.get(i);
if (configResults.isValid()) {
@@ -173,7 +173,7 @@
// Remove qualification from test name
StringTokenizer tokenizer = new StringTokenizer(testName, " :,", true); //$NON-NLS-1$
- StringBuffer buffer = new StringBuffer(tokenizer.nextToken());
+ StringBuilder buffer = new StringBuilder(tokenizer.nextToken());
while (tokenizer.hasMoreTokens()) {
String token = tokenizer.nextToken();
char fc = token.charAt(0);
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ComponentResultsElement.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ComponentResultsElement.java
index d40d9cb..3c61515 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ComponentResultsElement.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ComponentResultsElement.java
@@ -196,12 +196,12 @@
}
@Override
-StringBuffer getFailures(StringBuffer buffer, int kind, StringBuffer excluded) {
+StringBuilder getFailures(StringBuilder buffer, int kind, StringBuilder excluded) {
// Write status for scenarios having error
if ((getStatus() & ERROR_MASK) != 0) {
// Get children status
- StringBuffer childrenBuffer = super.getFailures(new StringBuffer(), kind, excluded);
+ StringBuilder childrenBuffer = super.getFailures(new StringBuilder(), kind, excluded);
// Write status on file if not excluded
if (childrenBuffer.length() > 0) {
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ConfigResultsElement.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ConfigResultsElement.java
index 30bf3a2..89f3d4f 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ConfigResultsElement.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ConfigResultsElement.java
@@ -269,7 +269,7 @@
* Write the element status in the given stream
*/
@Override
-StringBuffer getFailures(StringBuffer buffer, int kind, StringBuffer excluded) {
+StringBuilder getFailures(StringBuilder buffer, int kind, StringBuilder excluded) {
if ((this.status & BIG_DELTA) != 0) { // there's a failure on this config
// Get numbers
@@ -311,7 +311,7 @@
double baselineValue = values[AbstractResults.BASELINE_VALUE_INDEX];
double delta = values[AbstractResults.DELTA_VALUE_INDEX];
double error = values[AbstractResults.DELTA_ERROR_INDEX];
- StringBuffer localBuffer = new StringBuffer(" ");
+ StringBuilder localBuffer = new StringBuilder(" ");
localBuffer.append(configResults.getName());
double[] stats = null;
boolean printValues = (kind & IPerformancesConstants.STATUS_VALUES) != 0;
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/PerformanceResultsElement.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/PerformanceResultsElement.java
index 16ffb99..102e5fe 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/PerformanceResultsElement.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/PerformanceResultsElement.java
@@ -218,15 +218,15 @@
/*
* Write the component status in the given file
*/
-public StringBuffer writeFailures(File resultsFile, int kind) {
+public StringBuilder writeFailures(File resultsFile, int kind) {
if (this.results == null) {
return null;
}
boolean values = (kind & IPerformancesConstants.STATUS_VALUES) != 0;
// Write status only for component with error
- StringBuffer excluded = new StringBuffer();
+ StringBuilder excluded = new StringBuilder();
try (DataOutputStream stream = new DataOutputStream(new BufferedOutputStream(new FileOutputStream(resultsFile)))) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
// Print build name
buffer.append("Status for ");
buffer.append(getPerformanceResults().getName());
@@ -314,7 +314,7 @@
buffer.append(Util.LINE_SEPARATOR);
}
stream.write(buffer.toString().getBytes());
- StringBuffer componentBuffer = getFailures(new StringBuffer(), kind, excluded);
+ StringBuilder componentBuffer = getFailures(new StringBuilder(), kind, excluded);
if (componentBuffer.length() > 0) {
stream.write(componentBuffer.toString().getBytes());
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ResultsElement.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ResultsElement.java
index 010bb21..5bc687d 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ResultsElement.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ResultsElement.java
@@ -229,10 +229,10 @@
}
final String getId() {
- return getId(new StringBuffer()).toString();
+ return getId(new StringBuilder()).toString();
}
-private StringBuffer getId(StringBuffer buffer) {
+private StringBuilder getId(StringBuilder buffer) {
if (this.parent != null) {
return this.parent.getId(buffer).append('/').append(getName());
}
@@ -573,7 +573,7 @@
/*
* Write the failures of the element in the given buffer
*/
-StringBuffer getFailures(StringBuffer buffer, int kind, StringBuffer excluded) {
+StringBuilder getFailures(StringBuilder buffer, int kind, StringBuilder excluded) {
int length = getChildren().length;
for (int i=0; i<length; i++) {
this.children[i].getFailures(buffer, kind, excluded);
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ScenarioResultsElement.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ScenarioResultsElement.java
index 21ce9cc..717257e 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ScenarioResultsElement.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/model/ScenarioResultsElement.java
@@ -127,12 +127,12 @@
}
@Override
-StringBuffer getFailures(StringBuffer buffer, int kind, StringBuffer excluded) {
+StringBuilder getFailures(StringBuilder buffer, int kind, StringBuilder excluded) {
// Write status for scenarios having error
if ((getStatus() & ERROR_MASK) != 0) {
// Get children status
- StringBuffer childrenBuffer = super.getFailures(new StringBuffer(), kind, excluded);
+ StringBuilder childrenBuffer = super.getFailures(new StringBuilder(), kind, excluded);
// Write status on file if not excluded
if (childrenBuffer.length() > 0) {
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTab.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTab.java
index 1abc3e8..f3ed434 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTab.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTab.java
@@ -367,14 +367,14 @@
final double error = values[AbstractResults.DELTA_ERROR_INDEX];
// Set text with delta value
- final StringBuffer address = new StringBuffer("http://fullmoon.ottawa.ibm.com/downloads/drops/");
+ final StringBuilder address = new StringBuilder("http://fullmoon.ottawa.ibm.com/downloads/drops/");
address.append(currentBuild);
address.append("/performance/");
address.append(configResults.getName());
address.append('/');
address.append(scenarioResults.getFileName());
address.append(".html");
- StringBuffer buffer = new StringBuffer("<a href=\"");
+ StringBuilder buffer = new StringBuilder("<a href=\"");
buffer.append(address);
buffer.append("\">");
final String itemText = Util.PERCENTAGE_FORMAT.format(delta);
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTable.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTable.java
index 21b4bd4..069922d 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTable.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsComparisonTable.java
@@ -102,7 +102,7 @@
} else {
// first line
StringTokenizer tokenizer = new StringTokenizer(boxName.substring(0, idx).trim(), " ");
- StringBuffer buffer = new StringBuffer(tokenizer.nextToken());
+ StringBuilder buffer = new StringBuilder(tokenizer.nextToken());
while (tokenizer.hasMoreTokens()) {
buffer.append(" ");
buffer.append(tokenizer.nextToken());
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsView.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsView.java
index b87365a..695256d 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsView.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/BuildsView.java
@@ -592,7 +592,7 @@
MessageDialog.openError(this.shell, getTitleToolTip(), "Error while updating database results constants!\nOpen error log to see more details on this error");
}
} else if (updated) {
- StringBuffer message = new StringBuffer("Database connection has been correctly ");
+ StringBuilder message = new StringBuilder("Database connection has been correctly ");
message.append( connected ? "opened." : "closed.");
MessageDialog.openInformation(this.shell, getTitleToolTip(), message.toString());
} else {
@@ -794,7 +794,7 @@
}
// Write status
- StringBuffer excluded = this.results.writeFailures(resultsFile, writeStatusValue);
+ StringBuilder excluded = this.results.writeFailures(resultsFile, writeStatusValue);
if (excluded == null) {
MessageDialog.openWarning(this.shell, getTitleToolTip(), "The component is not read, hence no results can be written!");
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/ComponentResultsView.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/ComponentResultsView.java
index 7f2b55c..350f471 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/ComponentResultsView.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/ComponentResultsView.java
@@ -444,66 +444,4 @@
// do nothing
}
-/*
- * Set the name of the part.
- * This name is built from the name of the component selected in the Components view.
- * The rules to build the name are:
- * 1. If the component name does not start then the part name is just "'<component name>' results"
- * 2. Otherwise, remove "org.eclipse." form the component name and count the tokens separated by a dot ('.')
- * a. if there's only one remaining token, then the part name is "Platform/"
- * + "<token uppercased>" if token is less than 3 characters,"<token with first char uppercased>" otherwise
- * b. otherwise then the part name is "<first token uppercased>"
- * + for each followed additional token:
- * "<token uppercased>" if token is less than 3 characters,"<token with first char uppercased>" otherwise
- * + " results"
- * E.g.
- * - org.eclipse.ui -> "Platform/UI"
- * - org.eclipse.swt -> "Platform/SWT"
- * - org.eclipse.team -> "Platform/Team"
- * - org.eclipse.jdt.ui -> "JDT/UI"
- * - org.eclipse.jdt.core -> "JDT/Core"
- * - org.eclipse.pde.api.tools -> "PDE/API Tools"
- *
-protected void setPartName() {
- String componentName = this.componentResultsElement.getName();
- String partName;
- StringBuffer buffer = null;
- if (componentName.startsWith(ORG_ECLIPSE)) {
- partName = componentName.substring(ORG_ECLIPSE.length());
- StringTokenizer tokenizer = new StringTokenizer(partName, ".");
- while (tokenizer.hasMoreTokens()) {
- String token = tokenizer.nextToken();
- if (buffer == null) {
- if (tokenizer.hasMoreTokens()) {
- buffer = new StringBuffer("'"+token.toUpperCase());
- buffer.append('/');
- } else {
- buffer = new StringBuffer("'Platform/");
- if (token.length() > 3) {
- buffer.append(Character.toUpperCase(token.charAt(0)));
- buffer.append(token.substring(1));
- } else {
- buffer.append(token.toUpperCase());
- }
- }
- } else {
- if (token.length() > 3) {
- buffer.append(Character.toUpperCase(token.charAt(0)));
- buffer.append(token.substring(1));
- } else {
- buffer.append(token.toUpperCase());
- }
- if (tokenizer.hasMoreTokens()) buffer.append(' ');
- }
- }
- } else {
- buffer = new StringBuffer("'");
- buffer.append(componentName);
- buffer.append("'");
- }
- buffer.append("' results");
- setPartName(buffer.toString());
-}
-*/
-
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/PerformanceResultsPreferencePage.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/PerformanceResultsPreferencePage.java
index ff0e826..6f342be 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/PerformanceResultsPreferencePage.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/ui/PerformanceResultsPreferencePage.java
@@ -238,7 +238,7 @@
this.milestonesCombo.setToolTipText("Enter the date of the milestone as yyyymmddHHMM");
// Default dimension layout
- StringBuffer tooltip = new StringBuffer("Select the default dimension which will be used for performance results\n");
+ StringBuilder tooltip = new StringBuilder("Select the default dimension which will be used for performance results\n");
tooltip.append("When changed, the new selected dimension is automatically added to the dimensions list below...");
String tooltipText = tooltip.toString();
Composite compositeDefaultDimension = createComposite(parent, 3, 1);
@@ -248,7 +248,7 @@
this.defaultDimensionCombo.setToolTipText(tooltipText);
// Results dimensions layout
- tooltip = new StringBuffer("Select the dimensions which will be used while generating performance results\n");
+ tooltip = new StringBuilder("Select the dimensions which will be used while generating performance results\n");
tooltip.append("When changed, the default dimension above is automatically added to the new list...");
tooltipText = tooltip.toString();
Composite compositeResultsDimensions = createComposite(parent, 3, 1);
@@ -1032,7 +1032,7 @@
}
File dbDir = new File(path, "perfDb"+version);
if (!dbDir.exists() || !dbDir.isDirectory()) {
- StringBuffer message = new StringBuffer("Invalid performance database directory\n");
+ StringBuilder message = new StringBuilder("Invalid performance database directory\n");
message.append(path+" should contain 'perfDb");
message.append(version);
message.append("' directory and none was found!");
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/utils/Util.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/utils/Util.java
index 24de1f8..f1a050e 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/utils/Util.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/internal/performance/results/utils/Util.java
@@ -176,7 +176,7 @@
*/
public static String componentDisplayName(String componentName) {
String partName;
- StringBuffer buffer = null;
+ StringBuilder buffer = null;
if (componentName.startsWith(ORG_ECLIPSE)) {
partName = componentName.substring(ORG_ECLIPSE.length());
StringTokenizer tokenizer = new StringTokenizer(partName, ".");
@@ -184,10 +184,10 @@
String token = tokenizer.nextToken();
if (buffer == null) {
if (tokenizer.hasMoreTokens()) {
- buffer = new StringBuffer("'" + token.toUpperCase());
+ buffer = new StringBuilder("'" + token.toUpperCase());
buffer.append('/');
} else {
- buffer = new StringBuffer("'Platform/");
+ buffer = new StringBuilder("'Platform/");
if (token.length() > 3) {
buffer.append(Character.toUpperCase(token.charAt(0)));
buffer.append(token.substring(1));
@@ -206,7 +206,7 @@
}
}
} else {
- buffer = new StringBuffer("'");
+ buffer = new StringBuilder("'");
buffer.append(componentName);
buffer.append("'");
}
@@ -531,7 +531,7 @@
if (time < 1000) { // less than 1s
return "00:00:00"; //$NON-NLS-1$
}
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
int seconds = (int) (time / 1000);
if (seconds < 60) {
buffer.append("00:00:"); //$NON-NLS-1$
@@ -604,7 +604,7 @@
public static String timeString(long time) {
NumberFormat format = NumberFormat.getInstance();
format.setMaximumFractionDigits(1);
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
if (time == 0) {
// print nothing
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/BarGraph.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/BarGraph.java
index a93d0fd..bc5a36b 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/BarGraph.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/BarGraph.java
@@ -35,7 +35,7 @@
private static final int SLANT= 8; // slant of break
private static final int GAP2= 5; // width of break
- private StringBuffer fAreaBuffer;
+ private StringBuilder fAreaBuffer;
private static class BarItem {
@@ -273,7 +273,7 @@
if (hasURL) {
if (this.fAreaBuffer == null)
- this.fAreaBuffer= new StringBuffer();
+ this.fAreaBuffer= new StringBuilder();
this.fAreaBuffer.append(" echo '<area shape=\"RECT\" coords=\"0," + y0 + ',' + width + ',' + y + "\" href=\"" + bar.url + "\">';\n");
}
}
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrint.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrint.java
index 9b3b6f4..2e0cf0d 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrint.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrint.java
@@ -60,7 +60,7 @@
if (currentUnderscoreIndex != -1){
buildName = buildName.substring(0, currentUnderscoreIndex);
}
- StringBuffer buffer = new StringBuffer("FP_");
+ StringBuilder buffer = new StringBuilder("FP_");
if (this.component != null) {
buffer.append(this.component);
buffer.append('_');
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrintGraph.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrintGraph.java
index 808ad51..9215203 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrintGraph.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrintGraph.java
@@ -263,7 +263,7 @@
this.gc.fillRectangle(recError);
Rectangle rec = new Rectangle(MARGIN, y + (GAP/2), baselineBarLength+baselineErrorLength, BAR_HEIGHT);
this.gc.drawRectangle(rec);
- StringBuffer tooltip = new StringBuffer("Time for baseline build ");
+ StringBuilder tooltip = new StringBuilder("Time for baseline build ");
tooltip.append(baselineBuildResults.getName());
tooltip.append(": ");
tooltip.append(Util.timeString((long)baselineValue));
@@ -310,7 +310,7 @@
this.gc.fillRectangle(recError);
Rectangle rec = new Rectangle(MARGIN, y + (GAP/2) + BAR_HEIGHT, currentBarLength+currentErrorLength, BAR_HEIGHT);
this.gc.drawRectangle(rec);
- StringBuffer tooltip = new StringBuffer("Time for current build ");
+ StringBuilder tooltip = new StringBuilder("Time for current build ");
tooltip.append(currentBuildResults.getName());
tooltip.append(": ");
tooltip.append(Util.timeString((long)currentValue));
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/GenerateResults.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/GenerateResults.java
index b75ae8b..380e252 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/GenerateResults.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/GenerateResults.java
@@ -199,7 +199,7 @@
* results object.
*/
private void parse(String[] args) {
- StringBuffer buffer = new StringBuffer("Parameters used to generate performance results (");
+ StringBuilder buffer = new StringBuilder("Parameters used to generate performance results (");
buffer.append(new SimpleDateFormat().format(new Date(System.currentTimeMillis())));
buffer.append("):\n");
int i = 0;
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/LineGraph.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/LineGraph.java
index 6ebd28a..6348195 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/LineGraph.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/LineGraph.java
@@ -22,7 +22,7 @@
public class LineGraph {
- StringBuffer fAreaBuffer;
+ StringBuilder fAreaBuffer;
private static class GraphItem {
@@ -134,7 +134,7 @@
g.fillOval(xposition-2, yposition-2, 5, 5);
if (this.fAreaBuffer == null)
- this.fAreaBuffer= new StringBuffer();
+ this.fAreaBuffer= new StringBuilder();
this.fAreaBuffer.append("\r<area shape=\"CIRCLE\" coords=\""+(xposition-2)+','+(yposition-2)+','+5+" alt=\""+ thisItem.title+": "+thisItem.description+"\""+ " title=\""+ thisItem.title+": "+thisItem.description+"\">");
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/RawDataTable.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/RawDataTable.java
index 841ae1d..11690b5 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/RawDataTable.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/RawDataTable.java
@@ -63,7 +63,7 @@
* Print table columns headers.
*/
private void printColumnHeaders() {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
int length = this.dimensions.length;
for (int i=0; i<length; i++) {
buffer.append("<td><b>");
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/ScenarioStatusTable.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/ScenarioStatusTable.java
index 93f56a2..c25c1da 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/ScenarioStatusTable.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/ScenarioStatusTable.java
@@ -113,7 +113,7 @@
} else {
// first line
StringTokenizer tokenizer = new StringTokenizer(boxName.substring(0, idx).trim(), " ");
- StringBuffer buffer = new StringBuffer(tokenizer.nextToken());
+ StringBuilder buffer = new StringBuilder(tokenizer.nextToken());
while (tokenizer.hasMoreTokens()) {
buffer.append(" ");
buffer.append(tokenizer.nextToken());
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/TimeLineGraph.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/TimeLineGraph.java
index 928389a..06e29f3 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/TimeLineGraph.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/TimeLineGraph.java
@@ -121,7 +121,7 @@
g.drawRectangle(xposition -4, yposition - 4, 8, 8);
if (this.fAreaBuffer == null)
- this.fAreaBuffer = new StringBuffer();
+ this.fAreaBuffer = new StringBuilder();
this.fAreaBuffer.append("\r<area shape=\"circle\" coords=\""
+ (xposition - 2) + ',' + (yposition - 2) + ',' + 5
diff --git a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/Utils.java b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/Utils.java
index b8eb443..831c076 100644
--- a/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/Utils.java
+++ b/bundles/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/Utils.java
@@ -334,7 +334,7 @@
* @return The failure message. May be empty if stats are good...
*/
public static String failureMessage(double[] resultStats, boolean full) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
int level = confidenceLevel(resultStats);
// boolean isWarn = (level & WARN) != 0;
boolean isErr = (level & ERR) != 0;
