| commit | 2727c0c300cefda65f4e3ebfe86674dcc1e639d6 | [log] [tgz] |
|---|---|---|
| author | Lars Vogel <Lars.Vogel@vogella.com> | Tue Feb 14 10:32:51 2017 +0100 |
| committer | Leo Ufimtsev <lufimtse@redhat.com> | Fri Jul 28 17:10:50 2017 -0400 |
| tree | e3ccc6ebec9ed5d5b73b936ac82d066fb617d847 | |
| parent | 814a6c07cc4fc11b999a980062bc71bd2d35b5e4 [diff] |
Bug 512159 - [CTabFolder] Several getter methods in CTabFolder do not
use checkWidget()
Not sure why these methods do not use checkWidget. The last commit
message for Silenio is: "restore HEAD after accidental deletion by error
in automated build script" which is not very informative.
Leo:
While reviewing, I found a bunch of other places that had checkWidget()
commented out.
The original commit that added them has an empty log message
and is not linked to bugzilla:
6a87ceb8219d8d816e8c34a66f6f56af4e43ead7
Author: Veronika Irvine <veronika>
Date: Fri Feb 15 13:55:04 2002 +0000
*** empty log message ***
I can only presume that it might have been done so that fields
can be accessed on the same thread without having to get the UI
thread for convienience. But for sake of consistency, we should
have these checks in all public methods.
Change-Id: I719fb7edf56fd6bface0eaf1b501856af0996b74
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!