| commit | 265c4b7facd5e415064af4d73f364f15b6fb10cd | [log] [tgz] |
|---|---|---|
| author | Eric Williams <ericwill@redhat.com> | Thu Jun 14 12:16:46 2018 -0400 |
| committer | Eric Williams <ericwill@redhat.com> | Wed Jun 20 13:38:10 2018 -0400 |
| tree | 59a8fc01dabceaa7ec692faf416befd9c1459b44 | |
| parent | 3f113f62ad723f939fc4b4f97642cff8c2a814c6 [diff] |
Bug 535124: CSS tree selection issue on Linux only This patch reverts some changes made to custom drawn Trees which fixed bugs on lower versions of GTK3 (3.14 and below). Unfortunately these changes broke some basic Tree selection background/foreground drawing. On GTK3 we need to use the clipping from the cairo context provided by the gtk_cell_renderer_render() function. It provides the x and width values. The y and height values can continue to be fetched via gtk_tree_view_get_background_area(). Tested on GTK3.22 with the sample project provided in the bug report, and the snippet attached to this patch. Testing in a child Eclipse shows no ill effects in the call hierarchy, open type dialog, package explorer, etc. No AllNonBrowser JUnit tests fail. Change-Id: I57933468313376f6d3735644fc9a5eb19fee3c99 Signed-off-by: Eric Williams <ericwill@redhat.com>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!