| commit | 845e7d1f3f135a66577827d15eed227d84cd26de | [log] [tgz] |
|---|---|---|
| author | Simeon Andreev <simeon.danailov.andreev@gmail.com> | Fri May 21 11:43:19 2021 +0200 |
| committer | Andrey Loskutov <loskutov@gmx.de> | Mon Jun 07 12:17:19 2021 -0400 |
| tree | 763bf7c3c6802b53edb76e7dbb0066f506795893 | |
| parent | 0e5010e86bd35a230fd68999168e717221d357ec [diff] |
Bug 573633 - [GTK3] Tree.setImage() leaks native memory This change adds missing free calls to pixbuf objects created by TreeItem.setImage() and TableItem.setImage(), preventing native memory leaks. According to the documentation of gtk_tree_store_set() and gtk_list_store_set(), the call will reference the pixbuf in question. Its therefore safe to unref it after the call, allowing GTK+ to eventually free the memory on tree destruction. Change-Id: Id54bedb6bbe6bed5075605ae7bbb3b69c48b00a3 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/180858 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!