commit | dc4f695412958c9ff9c22dfc4b079ccf87095d00 | [log] [tgz] |
---|---|---|
author | Leo Ufimtsev <lufimtse@redhat.com> | Mon May 22 17:54:42 2017 -0400 |
committer | Alexander Kurtakov <akurtako@redhat.com> | Wed Jun 28 04:22:45 2017 -0400 |
tree | b65485e1a4236a569dc4b3ce8b8708950f159b32 | |
parent | 2cc5d79e31d0f238b27ff78360cbac4007e4c7cd [diff] |
Bug 514719: [Browser][Webkit2] port Browser.getText() to webkit2 Webkit2 implementation of getText(). Implementation is similar to evaluate(), in that it converts async call to sync by waiting for async callback. It piggybacks on evaluate's async-callback framework. As both use the same framework, I abstracted the framework from being specific to 'evaluate' to a generic 'asyncToSync'. Test: - Checkout this patch - Cherry pick jUnit patch: (if not merged yet). https://git.eclipse.org/r/#/c/96984/ - Run Test_org_eclipse_swt_browser_Browser - All newly added getText() jUnits pass on Webkit2. Gtk3.22, Webkit2.16.1 Change-Id: I0a1d4e94b3a78abba4be9acb5a3f43311d023059 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514719 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!