| commit | c4d47a36c98fb73ce1c4be38df907dc309168c5b | [log] [tgz] |
|---|---|---|
| author | Simeon Andreev <simeon.danailov.andreev@gmail.com> | Wed Mar 16 09:06:25 2022 +0100 |
| committer | Andrey Loskutov <loskutov@gmx.de> | Thu Mar 17 09:25:13 2022 -0400 |
| tree | b5b28455af6adc6e275b0098a88e802fca3da89b | |
| parent | 3f8b90af7b5b14184beab6d8674280d69b37bd98 [diff] |
Bug 579257 - Eclipse browser cannot open a link with target="new" When creating a WebKit browser view in a new Shell, due to following a link with property target="new", WebKit expects to be given a "related" browser. Otherwise the "ready-to-show" signal is not emitted for the new browser view. Changes for bug 570379 already introduce code that attempts to call webkit_web_view_new_with_related_view() in the case of creating a browser view during the "create" signal of another browser. However, the changes do not address widget hierarchies more complex than a Shell as a direct parent of a Browser. This change adds a static field org.eclipse.swt.browser.WebKit.parentBrowser, which is set during propagation of the "create" signal for a WebKit browser view (i.e. during org.eclipse.swt.browser.WebKit.webkit_create_web_view()). The new field is then used if a new WebKit Browser is created during the "create" signal, while notifying any registered OpenWindowListener. This change does not help in cases where the new window browser is not created during a OpenWindowListener notification (i.e. during the "create" WebKit signal). Change-Id: I4a3d550549485a060e1db456087e5325451f39c8 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/191941 Tested-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!