| commit | 6b5a2bc28086a89bbeb698524d34f1666fb1fbff | [log] [tgz] |
|---|---|---|
| author | Leo Ufimtsev <lufimtse@redhat.com> | Wed Jan 03 12:48:06 2018 -0500 |
| committer | Leo Ufimtsev <lufimtse@redhat.com> | Wed Jan 03 15:45:37 2018 -0500 |
| tree | ebcae826bd8cbb09d09c807c399238afef67be12 | |
| parent | 8012cb0e186aade8c39968623a05ce92c363bf9c [diff] |
Bug 529352 (swtGdbusBindingsInCommonCode) part 2/2 Move funcs. - Moved GDBus function into OS.java - Making dynamic functions non-dynamic. All functions are since 2.24 or 2.26 (Gtk2 minimum is 2.28). So static functions are OK. - Found a cast bug. (int should have been a long). Phew, this could have caused very strange crasher! Making functions static helps prevent such bugs as we get compile errors! - Added comment about gtk/glib link and how to find. Verified with recompile and webkit2 jUnits. Patchset 3: - Removing asserts from static glib function. - Adding assert to a dynamic glib function. - Adding guard in webkit to prevent jvm crasher. - Observe glib/gtk comment explaining how gtk/glib lik on OS.java:786 Patchest 5: - changed to min glib version instead of gtk versions as older gtk can use newer glib. - Updated comment to reflect this one-way link. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=529352 Change-Id: Ibddc0e315334958f3f89871f7a5e57925a5b5282 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!