| commit | 5ccd99b1763a271291710a2a3ed1df3894c149a6 | [log] [tgz] |
|---|---|---|
| author | Leo Ufimtsev <lufimtse@redhat.com> | Tue Jan 30 16:58:12 2018 -0500 |
| committer | Leo Ufimtsev <lufimtse@redhat.com> | Tue Jan 30 17:01:20 2018 -0500 |
| tree | 776ba16a8f8d31ff4882766c8787ed4744af356e | |
| parent | 9699273a0dd1d1b553030ea14d565c8fb142c1d0 [diff] |
Bug 529870 – [webkit2]BrowserProblem Fixing a corner case that can generate a deadlock. - A) User calls evaluate(SCRIPT) - B) The SCRIPT calls a BrowserFunction, (java/swt) - C) The BrowserFunction calls evaluate() Now webkit_web_view_run_javascript() in C never starts because webkit is still executing A. But A never finishes because it's waiting for C to complete to get a return value for A's callback. Solution: Don't allow blocking evaluation in BrowserFunction() callbacks. This shouldn't affect folks mostly, because from what I gather people use 'evaluate' as a form of execute(). This has gone unnoticed on Win32/Cocoa because issue isn't explicitly raised and 'evaluate()' return value wasn't used. Verified with AllBrowser JUnits. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=5298702 Change-Id: Iddc8c753051455f6706ea81db85e0c6610be11a9 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!