| commit | f387b612b083bd9768b6782dac9356762e8ed1ef | [log] [tgz] |
|---|---|---|
| author | Leo Ufimtsev <lufimtse@redhat.com> | Thu May 24 14:51:06 2018 -0400 |
| committer | Alexander Kurtakov <akurtako@redhat.com> | Mon May 28 09:16:20 2018 -0500 |
| tree | 0de3bcc2a6fa68c645dd2e2d7dfd44fed7670b8a | |
| parent | 8013c7c389dfeba82f5d1fa735b8830665010fab [diff] |
Bug 498217 [GTK3][DnD] Dragging parts does not show rectangle (fix) As of Gtk 3.9.1, Commit a60ccd3672467efb454b121993febc36f33cbc79, off-screen GDK windows are not processed. Because of this gtk doesn't send move events to SWT. Platform.UI uses an off-screen tracker for SWT.MOVE events to draw custom rectangles on a transparent shell for it's part-drag-preview. Drawing/updates for these broke because tracker is off screen and no longer sent mouse move events. Solution: If a tracker is to move off-screen, then instead draw it 1x1 and make it transparent. Tests: - Child eclipse. Now part-preview works when dragging editor/views around. - Snippet 31/23 (tracker) work as before. Note, this fix is only for X11. On Wayland part-preview is still broken due to bug 535083. This bugfix seems to make part-preview more fluent on wayland, but there's still a black shell over eclipse. https://bugs.eclipse.org/bugs/show_bug.cgi?id=498217 Change-Id: Ia69c494d3d08b9565e6647073bbfd4870f20ade3 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com> (cherry picked from commit 34be01e01753fd8ff9109cdad0dad9052e65dd4f)
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!