| commit | 6ebd7c95a5ba339f6c549d8fb3a54caefd9400c5 | [log] [tgz] |
|---|---|---|
| author | Phillip Webb <pwebb@pivotal.io> | Thu Oct 13 21:08:13 2016 -0700 |
| committer | Lakshmi Shanmugam <lshanmug@in.ibm.com> | Wed Jan 25 11:09:48 2017 +0530 |
| tree | fa8642752048f5f8dae1787c7e1b4e3654f70596 | |
| parent | 5f6c060d848f650286b47d65395a7af136cde55c [diff] |
Bug 481144 - [Cocoa] Text lowered badly on Widgets in Preference and
Properties
Update Font init method to directly use the system font
when possible.
Prior to this commit OSX 10.11 and higher (systems that use
the San Francisco font) can render with unusual spacing. The
root cause seems to be that the system font has an unusual
baseline when a system font is manipulated or obtained by
name.
Specifically:
- Calling `NSFont.systemFontOfSize` will return a font that
renders correctly.
- Calling `NSFont.boldSystemFontOfSize` will return a font
that renders correctly.
- Calling `NSFont.systemFontOfSize` followed by `NSFontManager
.convertFont` will return a font that renders too low.
- Calling `NSFont.fontWithName(".SF NS Text")` will return
a font that sometimes renders too low (things seem to
consistently go wrong when it's called after a
`convertFont` call).
The `Font.init` now attempts to deduce if the font requested
is actually a system font and use direct system font handles.
This update also seems to fix issue 486734.
Change-Id:Ic613f72b911822385dfb9f0b32f82d8a5d895c77
Signed-off-by: pwebb@pivotal.io
Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>Thanks for your interest in this project.
Information regarding source code management, builds, coding standards, and more.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!