Improve assertions in PluginActivationTests
assertEquals(0, variable) gives better output in case of failure than
assertTrue (variable==0)
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Change-Id: I41e18f3b6d5c717def71e17fcaae8a99f9f85547
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/192438
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/releng/PluginActivationTests.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/releng/PluginActivationTests.java
index 2069b35..31e22f6 100644
--- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/releng/PluginActivationTests.java
+++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/releng/PluginActivationTests.java
@@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.ui.tests.releng;
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertEquals;
import java.util.ArrayList;
import java.util.Arrays;
@@ -274,7 +274,7 @@
if (buf.length() > 0) {
printPluginStatus(true);
}
- assertTrue("Unexpected bundles in status active:\n" + buf, buf.length() == 0);
+ assertEquals("Unexpected bundles in status active:\n" + buf, 0, buf.length());
}
/**
@@ -315,6 +315,6 @@
if (buf.length() > 0) {
printPluginStatus(true);
}
- assertTrue("Bundles not active which used to be active:\n" + buf, buf.length() == 0);
+ assertEquals("Bundles not active which used to be active:\n" + buf, 0, buf.length());
}
}