Simplify if conditions. Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Change-Id: I84d69f83dff9642e005caca6c686224bbfac4dd0 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191709 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
diff --git a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF index 959b69f..ab140b2 100644 --- a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF +++ b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Bundle-ManifestVersion: 2 Bundle-Name: %name Bundle-SymbolicName: org.eclipse.ui.views.log;singleton:=true -Bundle-Version: 1.3.100.qualifier +Bundle-Version: 1.3.200.qualifier Bundle-Activator: org.eclipse.ui.internal.views.log.Activator Bundle-Vendor: %provider-name Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.2.0,4.0.0)",
diff --git a/bundles/org.eclipse.ui.views.log/pom.xml b/bundles/org.eclipse.ui.views.log/pom.xml index c5b61b2..f57bca8 100644 --- a/bundles/org.eclipse.ui.views.log/pom.xml +++ b/bundles/org.eclipse.ui.views.log/pom.xml
@@ -20,7 +20,7 @@ <groupId>org.eclipse.ui</groupId> <artifactId>org.eclipse.ui.views.log</artifactId> - <version>1.3.100-SNAPSHOT</version> + <version>1.3.200-SNAPSHOT</version> <packaging>eclipse-plugin</packaging> <properties>
diff --git a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java index 8423b72..b15b207 100644 --- a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java +++ b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialog.java
@@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2000, 2018 IBM Corporation and others. + * Copyright (c) 2000, 2022 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -751,7 +751,7 @@ String filtersString = memento.getString(FILTER_LIST); - if ((filterEnabled == null) || (filterEnabled.booleanValue() == false) || filtersString == null) { + if ((filterEnabled == null) || (!filterEnabled.booleanValue()) || filtersString == null) { return new String[0]; }
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java index a7506d7..6dd2922 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java
@@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2000, 2019 IBM Corporation and others. + * Copyright (c) 2000, 2022 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -1342,7 +1342,7 @@ List<IConfigurationElement> handledElements = new ArrayList<>(); handledElements.add(items.get(0)); // Hack!! startup seeding MUIElement createdTrim = null; - while (items.size() > 0 && handledElements.size() > 0) { + while (!items.isEmpty() && !handledElements.isEmpty()) { handledElements.clear(); for (IConfigurationElement item : items) { @@ -2174,7 +2174,7 @@ // do nothing } } - if (dirtyParts != null && dirtyParts.size() > 0) { + if (!dirtyParts.isEmpty()) { ISaveHandler saveHandler = context.get(ISaveHandler.class); if (saveHandler != null) { if (saveHandler instanceof WWinPartServiceSaveHandler) {
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java index 92d2331..38f8209 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java
@@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2005, 2015 IBM Corporation and others. + * Copyright (c) 2005, 2022 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -103,7 +103,7 @@ } private IWorkbenchBrowserSupport getActiveSupport() { - if (initialized == false) { + if (!initialized) { loadActiveSupport(); } // ensure we always have an active instance