Bug 507298 - Use fitting color for Heap Status (dark theme)
Patch to fix Heapstatus on Darktheme. (See screenshot)
- In Heapstatus, foreground color of text was not set properly.
- In e4-dark, heapstatus colors were not defined leading
to unsuitable defaults.
Change-Id: I7dbd5ce122dd53aa818d201b419a50deb154ac02
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
diff --git a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css
index 5c93a53..97e1c3a 100644
--- a/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css
+++ b/bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css
@@ -431,6 +431,11 @@
color: #EEEEEE;
}
+HeapStatus {
+ background-color: #4F5355;
+ color: #EEEEEE;
+}
+
PageSiteComposite, PageSiteComposite > CImageLabel {
color: #EEEEEE;
}
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java
index 83bc080..979931c 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java
@@ -227,9 +227,9 @@
@Override
public void setForeground(Color color) {
if (color == null) {
- usedMemCol = getDisplay().getSystemColor(SWT.COLOR_INFO_BACKGROUND);
+ markCol = textCol = getDisplay().getSystemColor(SWT.COLOR_INFO_BACKGROUND);
} else {
- usedMemCol = color;
+ markCol = textCol = color;
}
button.redraw();
