Bug 510213 - Code cleanup in org.eclipse.ui.forms.examples
Converts to enhanced for loops
Change-Id: I3eed8632d2accfa6c6b185faf2d253ab85f63622
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/NewStylePage.java b/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/NewStylePage.java
index c596126..2aed18b 100644
--- a/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/NewStylePage.java
+++ b/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/NewStylePage.java
@@ -288,9 +288,9 @@
Control[] children = client.getChildren();
ArrayList<Button> buttons = new ArrayList<>();
- for (int i = 0; i < children.length; i++) {
- if (children[i] instanceof Button) {
- Button button = (Button) children[i];
+ for (Control element : children) {
+ if (element instanceof Button) {
+ Button button = (Button) element;
if ((button.getStyle() & SWT.CHECK) != 0 && !button.equals(dbutton)) {
buttons.add(button);
}
@@ -311,8 +311,8 @@
addRemoveMessage((Button) e.widget, form.getMessageManager());
}
};
- for (int i = 0; i < checkboxes.length; i++)
- checkboxes[i].addSelectionListener(mmListener);
+ for (Button checkbox : checkboxes)
+ checkbox.addSelectionListener(mmListener);
final Button autoUpdate = toolkit.createButton(client2,
"Auto update message manager", SWT.CHECK);
@@ -386,8 +386,8 @@
IMessageManager mm = form.getMessageManager();
mm.setAutoUpdate(false);
if (selection) {
- for (int i = 0; i < checkboxes.length; i++) {
- addRemoveMessage(checkboxes[i], mm);
+ for (Button checkbox : checkboxes) {
+ addRemoveMessage(checkbox, mm);
}
}
else {
diff --git a/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/SimpleModel.java b/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/SimpleModel.java
index 6056720..1d5f85b 100644
--- a/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/SimpleModel.java
+++ b/examples/org.eclipse.ui.forms.examples/src/org/eclipse/ui/forms/examples/internal/rcp/SimpleModel.java
@@ -52,17 +52,17 @@
add(objects, false);
}
public void add(NamedObject[] objs, boolean notify) {
- for (int i = 0; i < objs.length; i++) {
- objects.add(objs[i]);
- objs[i].setModel(this);
+ for (NamedObject obj : objs) {
+ objects.add(obj);
+ obj.setModel(this);
}
if (notify)
fireModelChanged(objs, IModelListener.ADDED, "");
}
public void remove(NamedObject[] objs, boolean notify) {
- for (int i = 0; i < objs.length; i++) {
- objects.remove(objs[i]);
- objs[i].setModel(null);
+ for (NamedObject obj : objs) {
+ objects.remove(obj);
+ obj.setModel(null);
}
if (notify)
fireModelChanged(objs, IModelListener.REMOVED, "");
