Bug 550419 - "Save Resources" dialog shown when closing RCP app and
should not be
Need to consider only the non compatibility parts if the compatibility
parts list becomes empty because compatibility parts have
isSaveOnCloseNeeded() set to false.
Change-Id: I4cc6dd8986ce4173bd285a330602aeab47332f73
Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java
index dd6f64d..4bed5cd 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java
@@ -740,7 +740,11 @@
removeSaveOnCloseNotNeededParts(saveableParts);
}
if (saveableParts.isEmpty()) {
- return super.saveParts(dirtyParts, confirm);
+ if (nonCompatibilityParts.isEmpty()) {
+ // nothing to save
+ return true;
+ }
+ return super.saveParts(nonCompatibilityParts, confirm);
} else if (!nonCompatibilityParts.isEmpty()) {
return saveMixedParts(nonCompatibilityParts, saveableParts, confirm, addNonPartSources);
}
