Use System.lineSeparator()
Benefit of this way rather than System.getProperty("line.separator") is
that there are no security checks.
Change-Id: I1566a10342e62ad2a4262146bac525aaf1bbbec6
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>diff --git a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/BrowserLog.java b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/BrowserLog.java
index 5d54589..866bf0a 100644
--- a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/BrowserLog.java
+++ b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/BrowserLog.java
@@ -33,7 +33,7 @@
private String logFileName;
private boolean newSession;
DateFormat formatter = new SimpleDateFormat("MMM dd, yyyy kk:mm:ss.SS"); //$NON-NLS-1$
- String LN = System.getProperty("line.separator"); //$NON-NLS-1$
+ String LN = System.lineSeparator();
/**
* Constructor
*/
diff --git a/bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/SelectionData.java b/bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/SelectionData.java
index 6d3bff0..1f06706 100644
--- a/bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/SelectionData.java
+++ b/bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/SelectionData.java
@@ -40,7 +40,7 @@
public void addSegment(String text) {
if (segments.size() > 0) {
- segments.add(System.getProperty("line.separator")); //$NON-NLS-1$
+ segments.add(System.lineSeparator());
}
segments.add(text);
}
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerDescriptionHandler.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerDescriptionHandler.java
index 0ad0ab6..aed5f9a 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerDescriptionHandler.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerDescriptionHandler.java
@@ -31,7 +31,7 @@
* handler is executed.
*/
static String createMarkersReport(final IMarker[] markers) {
- final String NEWLINE = System.getProperty("line.separator"); //$NON-NLS-1$
+ final String NEWLINE = System.lineSeparator();
final StringBuilder report = new StringBuilder();
for (int i = 0; i < markers.length; i++) {
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerResourceQualifiedNameHandler.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerResourceQualifiedNameHandler.java
index dc39673..3a92ac3 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerResourceQualifiedNameHandler.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/CopyMarkerResourceQualifiedNameHandler.java
@@ -31,7 +31,7 @@
* handler is executed.
*/
static String createMarkersReport(final IMarker[] markers) {
- final String NEWLINE = System.getProperty("line.separator"); //$NON-NLS-1$
+ final String NEWLINE = System.lineSeparator();
final StringBuilder report = new StringBuilder();
for (int i = 0; i < markers.length; i++) {
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerCopyHandler.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerCopyHandler.java
index 62b4c31..a5d7fac 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerCopyHandler.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerCopyHandler.java
@@ -74,7 +74,7 @@
MarkerField[] fields = view.getVisibleFields();
- final String NEWLINE = System.getProperty("line.separator"); //$NON-NLS-1$
+ final String NEWLINE = System.lineSeparator();
final char DELIMITER = '\t';
// create header
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkNavigator.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkNavigator.java
index b9e8c6d..41c619c 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkNavigator.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkNavigator.java
@@ -465,7 +465,7 @@
.getLabelProvider();
for (int i = 0; i < markers.length; i++) {
if (i > 0) {
- buffer.append(System.getProperty("line.separator")); //$NON-NLS-1$
+ buffer.append(System.lineSeparator());
}
String text = provider.getText(markers[i]);
if(text != null) {
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/CopyBookmarkAction.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/CopyBookmarkAction.java
index 2b686d4..992e463 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/CopyBookmarkAction.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/CopyBookmarkAction.java
@@ -109,7 +109,7 @@
report.append(BookmarkMessages.ColumnResource_header).append('\t');
report.append(BookmarkMessages.ColumnFolder_header).append('\t');
report.append(BookmarkMessages.ColumnLocation_header);
- report.append(System.getProperty("line.separator")); //$NON-NLS-1$
+ report.append(System.lineSeparator());
// write markers
for (IMarker marker : markers) {
@@ -118,7 +118,7 @@
report.append(MarkerUtil.getContainerName(marker)).append('\t');
int line = MarkerUtil.getLineNumber(marker);
report.append(NLS.bind(BookmarkMessages.LineIndicator_text, String.valueOf(line)));
- report.append(System.getProperty("line.separator")); //$NON-NLS-1$
+ report.append(System.lineSeparator());
}
return report.toString();
diff --git a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogReader.java b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogReader.java
index 0fca23f..a4ca8e2 100644
--- a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogReader.java
+++ b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogReader.java
@@ -193,7 +193,7 @@
StringBuilder sb = new StringBuilder(current.getMessage());
String continuation = swriter.toString();
if (continuation.length() > 0)
- sb.append(System.getProperty("line.separator")).append(continuation); //$NON-NLS-1$
+ sb.append(System.lineSeparator()).append(continuation);
current.setMessage(sb.toString());
}
}
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java
index a0c0461..12fa9d7 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java
@@ -169,7 +169,7 @@
static final String KEYS_PREFERENCE_PAGE_ID = "org.eclipse.ui.preferencePages.Keys"; //$NON-NLS-1$
- static final String NEW_LINE = System.getProperty("line.separator"); //$NON-NLS-1$
+ static final String NEW_LINE = System.lineSeparator();
static final int MIN_TOOLTIP_WIDTH = 160;
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java
index 42de76e..7445dbe 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java
@@ -1233,7 +1233,7 @@
fileWriter.write(',');
}
}
- fileWriter.write(System.getProperty("line.separator")); //$NON-NLS-1$
+ fileWriter.write(System.lineSeparator());
}
} finally {
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java
index 8eab97e..feec9df 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java
@@ -470,7 +470,7 @@
buffer.append(ESCAPED_QUOTE + be.getTrigger().format() + ESCAPED_QUOTE + DELIMITER);
buffer.append(ESCAPED_QUOTE + be.getContext().getName() + ESCAPED_QUOTE + DELIMITER);
buffer.append(ESCAPED_QUOTE + be.getId() + ESCAPED_QUOTE);
- buffer.append(System.getProperty("line.separator")); //$NON-NLS-1$
+ buffer.append(System.lineSeparator());
fileWriter.write(buffer.toString());
}
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/DefaultDetailsArea.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/DefaultDetailsArea.java
index da8854e..2fb3613 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/DefaultDetailsArea.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/DefaultDetailsArea.java
@@ -301,7 +301,7 @@
}
private String getLineSeparator() {
- return System.getProperty("line.separator"); //$NON-NLS-1$
+ return System.lineSeparator();
}
private void appendNewLine(StyledText text, String line, int indentLevel, int lineNumber) {
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java
index 2b68e6d..cc381f6 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java
@@ -138,7 +138,7 @@
return ""; //$NON-NLS-1$
}
StringBuilder sb = new StringBuilder();
- String newLine = System.getProperty("line.separator"); //$NON-NLS-1$
+ String newLine = System.lineSeparator();
for (int i = 0; i < list.getItemCount(); i++) {
sb.append(list.getItem(i));
sb.append(newLine);
diff --git a/bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/DesktopFileWriter.java b/bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/DesktopFileWriter.java
index 3f8474b..e584319 100644
--- a/bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/DesktopFileWriter.java
+++ b/bundles/org.eclipse.urischeme/src/org/eclipse/urischeme/internal/registration/DesktopFileWriter.java
@@ -30,7 +30,7 @@
*/
public class DesktopFileWriter {
- private static final String LINE_SEPARATOR = System.getProperty("line.separator"); //$NON-NLS-1$
+ private static final String LINE_SEPARATOR = System.lineSeparator();
private static final String EQUAL_SIGN = "="; //$NON-NLS-1$
private static final String KEY_MIME_TYPE = "MimeType"; //$NON-NLS-1$
private static final String KEY_EXEC = "Exec"; //$NON-NLS-1$
diff --git a/tests/org.eclipse.tests.urischeme/src/org/eclipse/urischeme/internal/registration/TestUnitDesktopFileWriter.java b/tests/org.eclipse.tests.urischeme/src/org/eclipse/urischeme/internal/registration/TestUnitDesktopFileWriter.java
index 9abb6d6..78615dd 100644
--- a/tests/org.eclipse.tests.urischeme/src/org/eclipse/urischeme/internal/registration/TestUnitDesktopFileWriter.java
+++ b/tests/org.eclipse.tests.urischeme/src/org/eclipse/urischeme/internal/registration/TestUnitDesktopFileWriter.java
@@ -33,7 +33,7 @@
public class TestUnitDesktopFileWriter {
- private static final String LINE_SEPARATOR = System.getProperty("line.separator"); //$NON-NLS-1$
+ private static final String LINE_SEPARATOR = System.lineSeparator();
private static final String NO_MIME = "";
@Test
diff --git a/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/TestRunLogUtil.java b/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/TestRunLogUtil.java
index 81911cb..9d99792 100644
--- a/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/TestRunLogUtil.java
+++ b/tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/TestRunLogUtil.java
@@ -21,7 +21,7 @@
*/
public final class TestRunLogUtil {
- private static final String LINE_BREAK = System.getProperty("line.separator"); //$NON-NLS-1$
+ private static final String LINE_BREAK = System.lineSeparator();
/**
* A {@link TestWatcher} to log test start and end. Should be added as @Rule in
