Replace Expression Lambda with Method Reference in navigator Platform UI
This clean up simplifies expression lambdas by using method reference.
Improves the readability by removing unnecessary syntax.
jSparrow Clean up.
Change-Id: I87842b0b0899f4afb7636956f2efbf732f0afd2f
Signed-off-by: Ardit Ymeri <ardit.ymeri@splendit.at>
diff --git a/bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/navigator/resources/ResourceDropAdapterAssistant.java b/bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/navigator/resources/ResourceDropAdapterAssistant.java
index 3802742..cb3d12c 100644
--- a/bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/navigator/resources/ResourceDropAdapterAssistant.java
+++ b/bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/navigator/resources/ResourceDropAdapterAssistant.java
@@ -489,7 +489,7 @@
final PerformRefactoringOperation op = new PerformRefactoringOperation(refactoring,
CheckConditionsOperation.ALL_CONDITIONS);
- final IWorkspaceRunnable r = monitor -> op.run(monitor);
+ final IWorkspaceRunnable r = op::run;
returnStatus = null;
IRunnableWithProgress refactorOp = monitor -> {
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorDecoratingLabelProvider.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorDecoratingLabelProvider.java
index 3a3dea3..a4f0387 100644
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorDecoratingLabelProvider.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorDecoratingLabelProvider.java
@@ -192,7 +192,7 @@
String property= event.getProperty();
if (property.equals(JFacePreferences.QUALIFIER_COLOR) || property.equals(JFacePreferences.COUNTER_COLOR) || property.equals(JFacePreferences.DECORATIONS_COLOR)
|| property.equals(IWorkbenchPreferenceConstants.USE_COLORED_LABELS)) {
- Display.getDefault().asyncExec(() -> refresh());
+ Display.getDefault().asyncExec(this::refresh);
}
}
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorPlugin.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorPlugin.java
index 3c4ea33..feab507 100644
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorPlugin.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorPlugin.java
@@ -112,7 +112,7 @@
/** The id of the orge.eclipse.ui.navigator plugin. */
public static String PLUGIN_ID = "org.eclipse.ui.navigator"; //$NON-NLS-1$
- private BundleListener bundleListener = event -> NavigatorSaveablesService.bundleChanged(event);
+ private BundleListener bundleListener = NavigatorSaveablesService::bundleChanged;
/**
* This constant can be used via {@link CommonViewer#setData(String, Object)} to set/get the lisst
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CustomizationTab.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CustomizationTab.java
index 4a144ab..17ccadb 100644
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CustomizationTab.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CustomizationTab.java
@@ -41,7 +41,7 @@
private CheckboxTableViewer tableViewer;
private final Set checkedItems = new HashSet();
- private ICheckStateListener checkListener = event -> CustomizationTab.this.checkStateChanged(event);
+ private ICheckStateListener checkListener = CustomizationTab.this::checkStateChanged;
protected CustomizationTab(Composite parent,
INavigatorContentService aContentService) {
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/FrameAction.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/FrameAction.java
index 0e04fc3..31fed7f 100755
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/FrameAction.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/FrameAction.java
@@ -26,7 +26,7 @@
public abstract class FrameAction extends Action {
private FrameList frameList;
- private IPropertyChangeListener propertyChangeListener = event -> FrameAction.this.handlePropertyChange(event);
+ private IPropertyChangeListener propertyChangeListener = FrameAction.this::handlePropertyChange;
/**
* Constructs a new action for the specified frame list.
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/TreeViewerFrameSource.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/TreeViewerFrameSource.java
index 9b7d85b..8b29d8d 100755
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/TreeViewerFrameSource.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/framelist/TreeViewerFrameSource.java
@@ -44,7 +44,7 @@
* @param frameList
*/
public void connectTo(FrameList frameList) {
- frameList.addPropertyChangeListener(event -> TreeViewerFrameSource.this.handlePropertyChange(event));
+ frameList.addPropertyChangeListener(TreeViewerFrameSource.this::handlePropertyChange);
}
/**
diff --git a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigatorManager.java b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigatorManager.java
index d2d66b0..9476c98 100644
--- a/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigatorManager.java
+++ b/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigatorManager.java
@@ -267,7 +267,7 @@
MenuManager menuMgr = new MenuManager(contentService
.getViewerDescriptor().getPopupMenuId());
menuMgr.setRemoveAllWhenShown(true);
- menuMgr.addMenuListener(manager -> fillContextMenu(manager));
+ menuMgr.addMenuListener(this::fillContextMenu);
TreeViewer commonViewer = commonNavigator.getCommonViewer();
Menu menu = menuMgr.createContextMenu(commonViewer.getTree());
