Replace Equality Check with isEmpty in Platform UI ui.ide
The time complexity of any isEmpty() method implementation should be
O(1) whereas some implementations of size() can be O(n). Thus, using
this rule provides performance benefits.
jSparrow Cleanup
Change-Id: I18240d7aa9e939e45c99e225f2bd1f35f6a7213e
Signed-off-by: Ardit Ymeri <ardit.ymeri@splendit.at>
diff --git a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/FilteredResourcesSelectionDialog.java b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/FilteredResourcesSelectionDialog.java
index bc09715..f05e6d4 100644
--- a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/FilteredResourcesSelectionDialog.java
+++ b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/FilteredResourcesSelectionDialog.java
@@ -218,7 +218,7 @@
* @param text the new subtitle
*/
private void setSubtitle(String text) {
- if (text == null || text.length() == 0) {
+ if (text == null || text.isEmpty()) {
getShell().setText(title);
} else {
getShell().setText(title + " - " + text); //$NON-NLS-1$
@@ -680,7 +680,7 @@
private List<Position> getMatchPositions(String string, String matching) {
final String originalMatching = matching;
List<Position> positions = new ArrayList<>();
- if (matching.length() == 0 || string.length() == 0) {
+ if (matching.isEmpty() || string.isEmpty()) {
return positions;
}
@@ -973,7 +973,7 @@
filenamePattern = "**"; //$NON-NLS-1$
if (sep > 0) {
- if (filenamePattern.length() == 0) // relative patterns don't need a file name
+ if (filenamePattern.isEmpty()) // relative patterns don't need a file name
filenamePattern = "**"; //$NON-NLS-1$
String containerPattern = stringPattern.substring(0, sep);
diff --git a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java
index 5ae3a23..edafe1a 100644
--- a/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java
+++ b/bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java
@@ -200,7 +200,7 @@
protected IPath getPathFromText(Text textField) {
String text = textField.getText();
// Do not make an empty path absolute so as not to confuse with the root
- if (text.length() == 0) {
+ if (text.isEmpty()) {
return new Path(text);
}
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEEncoding.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEEncoding.java
index c774d03..d17749a 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEEncoding.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEEncoding.java
@@ -96,7 +96,7 @@
public static String getResourceEncoding() {
String preference = ResourcesPlugin.getPlugin().getPluginPreferences().getString(
ResourcesPlugin.PREF_ENCODING);
- if (preference == null || preference.length() == 0) {
+ if (preference == null || preference.isEmpty()) {
return null;
}
return preference;
@@ -158,7 +158,7 @@
String encodings = IDEWorkbenchPlugin.getDefault().getPreferenceStore().getString(
IDE_ENCODINGS_PREFERENCE);
- if (encodings == null || encodings.length() == 0) {
+ if (encodings == null || encodings.isEmpty()) {
return new ArrayList<>();
}
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/AbstractEncodingFieldEditor.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/AbstractEncodingFieldEditor.java
index 9d434c1..861f293 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/AbstractEncodingFieldEditor.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/AbstractEncodingFieldEditor.java
@@ -390,7 +390,7 @@
if (encodingSetting == null) {
// Changed if default is selected and there is no setting
- return current == null || current.length() == 0;
+ return current == null || current.isEmpty();
}
return encodingSetting.equals(current);
}
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/Util.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/Util.java
index 860fcbb..19de2c7 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/Util.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/Util.java
@@ -268,7 +268,7 @@
String result = marker.getResource().getProjectRelativePath()
.removeLastSegments(1).toOSString();
- if (result.trim().length() == 0) {
+ if (result.trim().isEmpty()) {
return MarkerMessages.Util_ProjectRoot;
}
return result;
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourcePatternFilter.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourcePatternFilter.java
index 4a17aa4..062124a 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourcePatternFilter.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourcePatternFilter.java
@@ -91,7 +91,7 @@
IPreferenceStore viewsPrefs = IDEWorkbenchPlugin.getDefault().getPreferenceStore();
String storedPatterns = viewsPrefs.getString(FILTERS_TAG);
- if (storedPatterns.length() == 0) {
+ if (storedPatterns.isEmpty()) {
// try to migrate patterns from old workbench preference store location
IPreferenceStore workbenchPrefs = PrefUtil.getInternalPreferenceStore();
storedPatterns = workbenchPrefs.getString(FILTERS_TAG);
@@ -101,7 +101,7 @@
}
}
- if (storedPatterns.length() == 0) {
+ if (storedPatterns.isEmpty()) {
// revert to all filter extensions with selected == "true"
// if there are no filters in the preference store
List<String> defaultFilters = FiltersContentProvider.getDefaultFilters();
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemStructureProvider.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemStructureProvider.java
index c011099..808d7bc 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemStructureProvider.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemStructureProvider.java
@@ -75,7 +75,7 @@
//Get the name - if it is empty then return the path as it is a file root
File file = (File) element;
String name = file.getName();
- if (name.length() == 0) {
+ if (name.isEmpty()) {
return file.getPath();
}
return name;
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/WizardExternalProjectImportPage.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/WizardExternalProjectImportPage.java
index 962058b..e5e57c1 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/WizardExternalProjectImportPage.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/WizardExternalProjectImportPage.java
@@ -277,11 +277,11 @@
dialog.setMessage(DataTransferMessages.WizardExternalProjectImportPage_directoryLabel);
String dirName = getProjectLocationFieldValue();
- if (dirName.length() == 0) {
+ if (dirName.isEmpty()) {
dirName = previouslyBrowsedDirectory;
}
- if (dirName.length() == 0) {
+ if (dirName.isEmpty()) {
dialog.setFilterPath(getWorkspace().getRoot().getLocation().toOSString());
} else {
File path = new File(dirName);
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewProjectResourceWizard.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewProjectResourceWizard.java
index 1511acb..b4cfdb9 100644
--- a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewProjectResourceWizard.java
+++ b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewProjectResourceWizard.java
@@ -556,7 +556,7 @@
}
String desc = finalPersp.getDescription();
String message;
- if (desc == null || desc.length() == 0)
+ if (desc == null || desc.isEmpty())
message = NLS.bind(ResourceMessages.NewProject_perspSwitchMessage,
finalPersp.getLabel());
else
