Bug 511387 - Remove unnecessary methods from TreeNodeContentProvider
Removed unnecessary dispose and inputChanged
Change-Id: I24c5a2514d7691706a3491197f51d8db9aac2af5
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Also-by: Karsten Thoms <karsten.thoms@karakun.com>
diff --git a/bundles/org.eclipse.jface/.settings/.api_filters b/bundles/org.eclipse.jface/.settings/.api_filters
index ecff00b..3ba5543 100644
--- a/bundles/org.eclipse.jface/.settings/.api_filters
+++ b/bundles/org.eclipse.jface/.settings/.api_filters
@@ -16,6 +16,20 @@
</message_arguments>
</filter>
</resource>
+ <resource path="src/org/eclipse/jface/viewers/TreeNodeContentProvider.java" type="org.eclipse.jface.viewers.TreeNodeContentProvider">
+ <filter comment="False positive: Empty implementation became obsolete with default implementation on interface IContentProvider" id="338792546">
+ <message_arguments>
+ <message_argument value="org.eclipse.jface.viewers.TreeNodeContentProvider"/>
+ <message_argument value="dispose()"/>
+ </message_arguments>
+ </filter>
+ <filter comment="False positive: Empty implementation became obsolete with default implementation on interface IContentProvider" id="338792546">
+ <message_arguments>
+ <message_argument value="org.eclipse.jface.viewers.TreeNodeContentProvider"/>
+ <message_argument value="inputChanged(Viewer, Object, Object)"/>
+ </message_arguments>
+ </filter>
+ </resource>
<resource path="src/org/eclipse/jface/widgets/ButtonFactory.java" type="org.eclipse.jface.widgets.ButtonFactory">
<filter comment="The method was moved to the super class so not API breakage" id="338792546">
<message_arguments>
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeNodeContentProvider.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeNodeContentProvider.java
index 3351f00..e580eaa 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeNodeContentProvider.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeNodeContentProvider.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2005, 2015 IBM Corporation and others.
+ * Copyright (c) 2005, 2020 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -31,11 +31,6 @@
public class TreeNodeContentProvider implements ITreeContentProvider {
@Override
- public void dispose() {
- // Do nothing
- }
-
- @Override
public Object[] getChildren(final Object parentElement) {
final TreeNode node = (TreeNode) parentElement;
return node.getChildren();
@@ -61,10 +56,5 @@
return node.hasChildren();
}
- @Override
- public void inputChanged(final Viewer viewer, final Object oldInput,
- final Object newInput) {
- // Do nothing
- }
}
