Fix shellcheck issues

Change-Id: I40a041d8dcf800cee6c11bc20451fd232d1b4a16
Signed-off-by: Frederic Gurr <frederic.gurr@eclipse-foundation.org>

infoCenter/k8s/createInfoCenter_yaml.sh

diff --git a/infoCenter/k8s/createInfoCenter_yaml.sh b/infoCenter/k8s/createInfoCenter_yaml.sh
index a2bba89..fae8b27 100755
--- a/infoCenter/k8s/createInfoCenter_yaml.sh
+++ b/infoCenter/k8s/createInfoCenter_yaml.sh
@@ -15,8 +15,8 @@
 set -o pipefail
 
 # Parameters:
-release_name=${1:-}
-sha_256=${2:-}
+release_name="${1:-}"
+sha_256="${2:-}"
 namespace="infocenter"
 hostname="help.eclipse.org"
 dockerhub_repo="eclipsecbi/eclipse-infocenter"
@@ -34,7 +34,7 @@
 fi
 
 create_license_header() {
-  local file=${1:-}
+  local file="${1:-}"
   local year="2019"
   cat <<EOF > ${file}
 #*******************************************************************************
@@ -49,11 +49,11 @@
 }
 
 create_route () {
-  local release_name=${1:-}
-  local namespace_name=${2:-}
-  local host_name=${3:-}
+  local release_name="${1:-}"
+  local namespace_name="${2:-}"
+  local host_name="${3:-}"
   local file_name="${release_name}/route.yml"
-  create_license_header ${file_name}
+  create_license_header "${file_name}"
   cat <<EOF >> ${file_name}
 apiVersion: "route.openshift.io/v1"
 kind: "Route"
@@ -80,10 +80,10 @@
 }
 
 create_service () {
-  local release_name=${1:-}
-  local namespace_name=${2:-}
+  local release_name="${1:-}"
+  local namespace_name="${2:-}"
   local file_name="${release_name}/service.yml"
-  create_license_header ${file_name}
+  create_license_header "${file_name}"
   cat <<EOF >> ${file_name}
 apiVersion: "v1"
 kind: "Service"
@@ -104,10 +104,10 @@
 }
 
 create_nginx_configmap () {
-  local release_name=${1:-}
-  local namespace_name=${2:-}
+  local release_name="${1:-}"
+  local namespace_name="${2:-}"
   local file_name="${release_name}/nginx-configmap.yml"
-  create_license_header ${file_name}
+  create_license_header "${file_name}"
   cat <<EOF >> ${file_name}
 apiVersion: v1
 kind: ConfigMap
@@ -140,15 +140,15 @@
 }
 
 create_statefulset () {
-  local release_name=${1:-}
-  local namespace_name=${2:-}
-  local sha256=${3:-}
+  local release_name="${1:-}"
+  local namespace_name="${2:-}"
+  local sha256="${3:-}"
   #local sha256="$(docker inspect --format='{{index .RepoDigests 0}}' "${dockerhub_repo}:${release_name}" | sed -E 's/.*sha256:(.*)/\1/g')"
   local file_name="${release_name}/statefulset.yml"
-  local infocenter_image=${dockerhub_repo}:${release_name}@sha256:${sha256}
+  local infocenter_image="${dockerhub_repo}:${release_name}@sha256:${sha256}"
   echo "Image name: ${infocenter_image}"
   
-  create_license_header ${file_name}
+  create_license_header "${file_name}"
   cat <<EOF >> ${file_name}
 apiVersion: apps/v1
 kind: StatefulSet
@@ -231,9 +231,9 @@
 EOF
 }
 
-mkdir -p ${release_name}
-create_route ${release_name} ${namespace} ${hostname}
-create_service ${release_name} ${namespace}
-create_nginx_configmap ${release_name} ${namespace}
-create_statefulset ${release_name} ${namespace} ${sha_256}
+mkdir -p "${release_name}"
+create_route "${release_name}" "${namespace}" "${hostname}"
+create_service "${release_name}" "${namespace}"
+create_nginx_configmap "${release_name}" "${namespace}"
+create_statefulset "${release_name}" "${namespace}" "${sha_256}"
 

infoCenter/k8s/deployInfoCenter.sh

diff --git a/infoCenter/k8s/deployInfoCenter.sh b/infoCenter/k8s/deployInfoCenter.sh
index 0f0237b..7ded5db 100755
--- a/infoCenter/k8s/deployInfoCenter.sh
+++ b/infoCenter/k8s/deployInfoCenter.sh
@@ -23,7 +23,9 @@
   exit 1
 fi
 
-oc apply -f ${release_name}/route.yml
-oc apply -f ${release_name}/service.yml
-oc apply -f ${release_name}/nginx-configmap.yml
-oc apply -f ${release_name}/statefulset.yml
+oc apply -f "${release_name}/route.yml"
+oc apply -f "${release_name}/service.yml"
+oc apply -f "${release_name}/nginx-configmap.yml"
+oc apply -f "${release_name}/statefulset.yml"
+oc delete pod "infocenter-${release_name}-0" -n infocenter --force --grace-period=0
+

infoCenter/k8s/update_sts.sh

diff --git a/infoCenter/k8s/update_sts.sh b/infoCenter/k8s/update_sts.sh
index a3938ae..d70149b 100755
--- a/infoCenter/k8s/update_sts.sh
+++ b/infoCenter/k8s/update_sts.sh
@@ -15,17 +15,17 @@
 set -o pipefail
 
 # Parameters:
-release_name=${1:-}
+release_name="${1:-}"
 
 # scale down and delete statefulset
-oc scale statefulset infocenter-${release_name} -n=infocenter --replicas=0
+oc scale statefulset "infocenter-${release_name}" -n=infocenter --replicas=0
 sleep 5
-oc get statefulset infocenter-${release_name} -n=infocenter
-oc delete pod infocenter-${release_name}-0 -n=infocenter --force --grace-period=0
+oc get statefulset "infocenter-${release_name}" -n=infocenter
+oc delete pod "infocenter-${release_name}-0" -n=infocenter --force --grace-period=0
 sleep 5
 oc get pods -n=infocenter
-oc delete statefulset infocenter-${release_name} -n=infocenter
+oc delete statefulset "infocenter-${release_name}" -n=infocenter
 sleep 5
 oc get statefulset -n=infocenter
 # apply statefulset
-oc apply -f ${release_name}/statefulset.yml
+oc apply -f "${release_name}/statefulset.yml"