Bug 568879: [Build] fix warnings, add code checkers
add findbugs configuration to allow
mvn findbugs:findbugs
Change-Id: Idabdcfb0d06b6b4a677fc6cb3e5a666731ea792a
diff --git a/plugins/org.eclipse.skills/.findbugs-exclude.xml b/plugins/org.eclipse.skills/.findbugs-exclude.xml
new file mode 100644
index 0000000..17c5c09
--- /dev/null
+++ b/plugins/org.eclipse.skills/.findbugs-exclude.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+ <!-- skip EMF generated packages -->
+ <Match>
+ <Package name="~org\.eclipse\.skills\.model.*" />
+ </Match>
+</FindBugsFilter>
\ No newline at end of file
diff --git a/plugins/org.eclipse.skills/pom.xml b/plugins/org.eclipse.skills/pom.xml
index 5db8480..27d908b 100644
--- a/plugins/org.eclipse.skills/pom.xml
+++ b/plugins/org.eclipse.skills/pom.xml
@@ -23,6 +23,17 @@
<excludes>**/org/eclipse/skills/model/**/*</excludes>
</configuration>
</plugin>
+
+ <!-- remove generated resources from findbugs code analysis -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${maven.findbugs.version}</version>
+ <configuration>
+ <excludeFilterFile>.findbugs-exclude.xml</excludeFilterFile>
+ </configuration>
+ </plugin>
+
</plugins>
</build>
diff --git a/releng/org.eclipse.skills.releng/pom.xml b/releng/org.eclipse.skills.releng/pom.xml
index 792e753..ffb92e7 100644
--- a/releng/org.eclipse.skills.releng/pom.xml
+++ b/releng/org.eclipse.skills.releng/pom.xml
@@ -18,6 +18,7 @@
<maven.buildhelper.version>1.9.1</maven.buildhelper.version>
<maven.pmd.version>3.13.0</maven.pmd.version>
<maven.checkstyle.version>3.1.1</maven.checkstyle.version>
+ <maven.findbugs.version>3.0.5</maven.findbugs.version>
<!-- build parameters -->
<compiler.compliance>1.8</compiler.compliance>
@@ -86,6 +87,13 @@
</configuration>
</plugin>
+ <!-- enable findbugs code analysis -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${maven.findbugs.version}</version>
+ </plugin>
+
<!-- enable tycho build extension -->
<plugin>
<groupId>org.eclipse.tycho</groupId>
