commit 11359ae2e232467d579fc4020d993ae25045016b
author nitind <nitind> Thu Sep 17 22:14:42 2009 +0000
committer nitind <nitind> Thu Sep 17 22:14:42 2009 +0000
tree 27b5efebe6bdab9c40b62332075740934c0a9deb
parent 928dc532b456e0d2e9a0f46f487944aeb2a8f0e4

[287096] ModelManagerImpl is highly susceptible to deadlock (preference value was ignored)

bundles/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/model/ModelManagerImpl.java

diff --git a/bundles/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/model/ModelManagerImpl.java b/bundles/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/model/ModelManagerImpl.java
index 72284d7..c16add8 100644
--- a/bundles/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/model/ModelManagerImpl.java
+++ b/bundles/org.eclipse.wst.sse.core/src/org/eclipse/wst/sse/core/internal/model/ModelManagerImpl.java
@@ -2191,7 +2191,7 @@
 				// +1, include the "."
 				key = property.substring(SSECorePlugin.ID.length() + 1, property.length());
 			}
-			preferencesService.getString(SSECorePlugin.ID, key, null, lookupOrder);
+			value = preferencesService.getString(SSECorePlugin.ID, key, null, lookupOrder);
 		}
 		
 		return value;