CleanUp: Remove unnecessary CopyOnWriteCollection.toList()
Change-Id: Ia6fc6274f08864febbc842bdd7976b9e35fae77f
diff --git a/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/internal/rj/eclient/graphics/EclipseRGraphic.java b/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/internal/rj/eclient/graphics/EclipseRGraphic.java
index 030da47..7e8d549 100644
--- a/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/internal/rj/eclient/graphics/EclipseRGraphic.java
+++ b/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/internal/rj/eclient/graphics/EclipseRGraphic.java
@@ -420,14 +420,14 @@
switch (type) {
case 1:
- for (final Listener listener : EclipseRGraphic.this.graphicListeners.toList()) {
+ for (final Listener listener : EclipseRGraphic.this.graphicListeners) {
if (listener instanceof ListenerLocatorExtension) {
((ListenerLocatorExtension) listener).locatorStarted();
}
}
break;
case 2:
- for (final Listener listener : EclipseRGraphic.this.graphicListeners.toList()) {
+ for (final Listener listener : EclipseRGraphic.this.graphicListeners) {
if (listener instanceof ListenerLocatorExtension) {
((ListenerLocatorExtension) listener).locatorStopped();
}
@@ -1250,7 +1250,7 @@
}
if (!this.message.equals(message)) {
this.message= message;
- for (final StatusChangeListener listener : this.messageListeners.toList()) {
+ for (final StatusChangeListener listener : this.messageListeners) {
listener.onStatusChanged(message);
}
}
diff --git a/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/rj/eclient/graphics/RGraphicCompositeActionSet.java b/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/rj/eclient/graphics/RGraphicCompositeActionSet.java
index 7dbf143..9216bce 100644
--- a/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/rj/eclient/graphics/RGraphicCompositeActionSet.java
+++ b/eclient/org.eclipse.statet.rj.eclient.graphics/src/org/eclipse/statet/rj/eclient/graphics/RGraphicCompositeActionSet.java
@@ -38,7 +38,6 @@
import org.eclipse.ui.services.IServiceLocator;
import org.eclipse.statet.jcommons.collections.CopyOnWriteIdentityListSet;
-import org.eclipse.statet.jcommons.collections.ImIdentityList;
import org.eclipse.statet.jcommons.status.ProgressMonitor;
import org.eclipse.statet.jcommons.status.Status;
import org.eclipse.statet.jcommons.status.StatusException;
@@ -463,14 +462,13 @@
}
private void notifyMouseLocationListeners(final double[] xy) {
- final ImIdentityList<LocationListener> listeners= this.mouseLocationListeners.toList();
if (xy != null) {
- for (final LocationListener listener : listeners) {
+ for (final LocationListener listener : this.mouseLocationListeners) {
listener.located(xy[0], xy[1]);
}
}
else {
- for (final LocationListener listener : listeners) {
+ for (final LocationListener listener : this.mouseLocationListeners) {
listener.loading();
}
}
diff --git a/servi/org.eclipse.statet.rj.servi/srcServiPool/org/eclipse/statet/internal/rj/servi/APool2NodeFactory.java b/servi/org.eclipse.statet.rj.servi/srcServiPool/org/eclipse/statet/internal/rj/servi/APool2NodeFactory.java
index b8ac23b..effa5be 100644
--- a/servi/org.eclipse.statet.rj.servi/srcServiPool/org/eclipse/statet/internal/rj/servi/APool2NodeFactory.java
+++ b/servi/org.eclipse.statet.rj.servi/srcServiPool/org/eclipse/statet/internal/rj/servi/APool2NodeFactory.java
@@ -114,7 +114,7 @@
throw new IllegalStateException("Pool not open");
}
- for (final PoolListener listener : this.poolListeners.toList()) {
+ for (final PoolListener listener : this.poolListeners) {
try {
listener.initializing(poolObj);
}
@@ -237,7 +237,7 @@
APool2NodeFactory.this.nodeFactory.stopNode(poolObj);
}
finally {
- for (final PoolListener listener : APool2NodeFactory.this.poolListeners.toList()) {
+ for (final PoolListener listener : APool2NodeFactory.this.poolListeners) {
try {
listener.disposed(poolObj);
}