kernel criticalpath: rename certain suffixes
Change-Id: I3390db18158db3b15c8b7c41037641ff81e9b6a5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/156443
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
diff --git a/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/CriticalPathWeighted.java b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/CriticalPathWeighted.java
index 9ed38f2..02776e8 100644
--- a/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/CriticalPathWeighted.java
+++ b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/CriticalPathWeighted.java
@@ -51,8 +51,9 @@
* An empty critical path
*/
private static final CriticalPathWeighted EMPTY_CRIT_PATH_CG = new CriticalPathWeighted();
- private static final String ALL_SUFFIX = "_all"; //$NON-NLS-1$
- private static final String PROCESS_SUFFIX = "_proc"; //$NON-NLS-1$
+ private static final String ALL_SUFFIX = String.valueOf(Messages.CriticalPathWeighted_ByStatus);
+ private static final String PROCESS_SUFFIX = String.valueOf(Messages.CriticalPathWeighted_ByProcessName);
+ private static final String THREAD_SUFFIX = String.valueOf(Messages.CriticalPathWeighted_ByThread);
private final List<String> fElements;
private WeightedTree<Object> fAggregatedTree;
@@ -215,8 +216,8 @@
if (worker == null) {
throw new NullPointerException("head vertex has no parent"); //$NON-NLS-1$
}
- fElements = ImmutableList.of(String.valueOf(worker), String.valueOf(worker) + ALL_SUFFIX, String.valueOf(worker) + PROCESS_SUFFIX);
- fTree = new WeightedTree<>(String.valueOf(worker));
+ fElements = ImmutableList.of(String.valueOf(worker) + THREAD_SUFFIX, String.valueOf(worker) + ALL_SUFFIX, String.valueOf(worker) + PROCESS_SUFFIX);
+ fTree = new WeightedTree<>(String.valueOf(worker) + THREAD_SUFFIX);
fAggregatedTree = new WeightedTree<>(String.valueOf(worker) + ALL_SUFFIX);
fProcessTree = new WeightedTree<>(String.valueOf(worker) + PROCESS_SUFFIX);
GraphToCallGraphConverter converter = new GraphToCallGraphConverter(worker, graph);
diff --git a/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/Messages.java b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/Messages.java
new file mode 100644
index 0000000..1f9150c
--- /dev/null
+++ b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/Messages.java
@@ -0,0 +1,35 @@
+/*******************************************************************************
+ * Copyright (c) 2020 École Polytechnique de Montréal
+ *
+ * All rights reserved. This program and the accompanying materials are
+ * made available under the terms of the Eclipse Public License v1.0 which
+ * accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *******************************************************************************/
+
+package org.eclipse.tracecompass.incubator.internal.kernel.core.criticalpath;
+
+import org.eclipse.jdt.annotation.Nullable;
+import org.eclipse.osgi.util.NLS;
+
+/**
+ * Messages for the aggregated critical path
+ *
+ * @author Geneviève Bastien
+ */
+public class Messages extends NLS {
+ private static final String BUNDLE_NAME = "org.eclipse.tracecompass.incubator.internal.kernel.core.criticalpath.messages"; //$NON-NLS-1$
+ /** String for the aggregation by process name */
+ public static @Nullable String CriticalPathWeighted_ByProcessName;
+ /** String for the aggregation by status */
+ public static @Nullable String CriticalPathWeighted_ByStatus;
+ /** String for the aggregation by thread */
+ public static @Nullable String CriticalPathWeighted_ByThread;
+ static {
+ // initialize resource bundle
+ NLS.initializeMessages(BUNDLE_NAME, Messages.class);
+ }
+
+ private Messages() {
+ }
+}
diff --git a/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/messages.properties b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/messages.properties
new file mode 100644
index 0000000..b83a12b
--- /dev/null
+++ b/analyses/org.eclipse.tracecompass.incubator.kernel.core/src/org/eclipse/tracecompass/incubator/internal/kernel/core/criticalpath/messages.properties
@@ -0,0 +1,12 @@
+###############################################################################
+# Copyright (c) 2020 École Polytechnique de Montréal
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Eclipse Public License v1.0
+# which accompanies this distribution, and is available at
+# http://www.eclipse.org/legal/epl-v10.html
+###############################################################################
+
+CriticalPathWeighted_ByProcessName=\ by process name
+CriticalPathWeighted_ByStatus=\ by status
+CriticalPathWeighted_ByThread=\ by thread
