commit 0a847513c0cbd2d69b1a0a49ab4785a9276b004f
author Marco Miller <marco.miller@ericsson.com> Thu Aug 25 16:39:59 2022 -0400
committer Patrick Tasse <patrick.tasse@gmail.com> Fri Aug 26 13:48:14 2022 -0400
tree e62f8c0b3f84e2ae9efab229e1edbfc196c025bb
parent c8142fdda874fa7637a97781418991bbcc33d9f1

Fix IDE warnings in TmfEventTableDataProviderTest

- Fix the Eclipse warning about a possibly null timestamp, to secure.
- Fix the Sonarlint issue about this redundant assignment; trivial.

Change-Id: Iecc2f2f25062a5a1654d726c7b838175e452657d
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/195369
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/TmfEventTableDataProviderTest.java

diff --git a/tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/TmfEventTableDataProviderTest.java b/tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/TmfEventTableDataProviderTest.java
index b696676..a75cb1a 100644
--- a/tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/TmfEventTableDataProviderTest.java
+++ b/tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/TmfEventTableDataProviderTest.java
@@ -107,7 +107,11 @@
     }
 
     private static String lineTimestamp(long millisecond) {
-        return TmfTimestamp.fromMillis(millisecond).toString();
+        String timestamp = TmfTimestamp.fromMillis(millisecond).toString();
+        if (timestamp == null) {
+            timestamp = "";
+        }
+        return timestamp;
     }
 
     private static String lineNsTimestamp(int millisecond) {
@@ -349,7 +353,6 @@
 
         TmfModelResponse<ITmfVirtualTableModel<EventTableLine>> response = fProvider.fetchLines(parameters, null);
         ITmfVirtualTableModel<EventTableLine> currentModel = response.getModel();
-        currentModel = response.getModel();
         assertNotNull(currentModel);
         assertTrue(currentModel.getLines().isEmpty());
         TmfVirtualTableModel<@NonNull EventTableLine> expectedModel = new TmfVirtualTableModel<>(expectedColumnsId, expectedData, 0, 10000);