Marks inactive test with @Ignore and adds TODO for review
diff --git a/org.eclipse.virgo.kernel.deployer/src/test/java/org/eclipse/virgo/kernel/install/artifact/internal/FileMovingArtifactStoreTests.java b/org.eclipse.virgo.kernel.deployer/src/test/java/org/eclipse/virgo/kernel/install/artifact/internal/FileMovingArtifactStoreTests.java
index 55ee137..2b5c57c 100644
--- a/org.eclipse.virgo.kernel.deployer/src/test/java/org/eclipse/virgo/kernel/install/artifact/internal/FileMovingArtifactStoreTests.java
+++ b/org.eclipse.virgo.kernel.deployer/src/test/java/org/eclipse/virgo/kernel/install/artifact/internal/FileMovingArtifactStoreTests.java
@@ -19,14 +19,15 @@
import org.eclipse.virgo.util.io.PathReference;
import org.junit.Before;
+import org.junit.Ignore;
import org.junit.Test;
public class FileMovingArtifactStoreTests {
-
+
private static final String TEST_PATH = "build/fileMovingArtifactStoreTests/";
-
+
private static final String TEST_FILENAME = "some.jar";
-
+
private ArtifactStore artifactHistory;
@Before
@@ -60,7 +61,7 @@
checkPath(c);
assertTrue(original.equals(c));
}
-
+
@Test
public void testRepeatedStash() {
PathReference original = this.artifactHistory.getCurrentPath();
@@ -72,7 +73,7 @@
assertTrue(original.equals(next));
assertTrue(original.equals(last));
}
-
+
@Test
public void testFileDeletionOnUnstash() {
this.artifactHistory.save();
@@ -103,7 +104,7 @@
this.artifactHistory.save();
assertFalse(c.exists());
}
-
+
@Test
public void testDirectoryDeletionOnDoubleStash() {
PathReference c = this.artifactHistory.getCurrentPath();
@@ -114,36 +115,38 @@
this.artifactHistory.save();
assertFalse(c.exists());
}
-
- @Test(expected=IllegalStateException.class)
+
+ @Test(expected = IllegalStateException.class)
public void testBadUnstash() {
this.artifactHistory.restore();
}
- @Test(expected=IllegalStateException.class)
+ @Test(expected = IllegalStateException.class)
public void testDoubleUnstash() {
this.artifactHistory.save();
this.artifactHistory.save();
this.artifactHistory.restore();
this.artifactHistory.restore();
}
-
- @Test(expected=IllegalArgumentException.class)
+
+ @Test(expected = IllegalArgumentException.class)
public void testNullConstructorPath() {
new FileMovingArtifactStore(null);
}
-
- @Test(expected=IllegalArgumentException.class)
+
+ @Test(expected = IllegalArgumentException.class)
public void testEmptyConstructorPath() {
new FileMovingArtifactStore(new PathReference(""));
}
-
+
+ @Test
+ @Ignore("review the inactive / failing test")
+ // TODO - review the (from the beginning) inactive test
public void testDirectorylessConstructorPath() {
ArtifactStore ph = new FileMovingArtifactStore(new PathReference("a"));
assertEquals("a", ph.getCurrentPath().getName());
}
-
private void checkPath(PathReference c) {
File file = c.toFile();
assertTrue(file.toURI().toString().indexOf(TEST_PATH) != -1);
@@ -155,4 +158,3 @@
}
}
-
