Bug 402478 - [coordinator] Be less aggressive with log messages when processing orphaned coordinations.
Changed unexpected exception logging when failing an orphaned coordination from ERROR to WARNING.
Changed unexpected exception logging when ending an orphaned coordination from ERROR to WARNING.
Changed unexpected coordination exception failure cause logging from ERROR to DEBUG.
Exception instead of Throwable now caught.
Updated copyrights, including one from previous change in CoordinationImpl.
diff --git a/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinationWeakReference.java b/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinationWeakReference.java
index 7c7d90c..33d5ef4 100644
--- a/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinationWeakReference.java
+++ b/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinationWeakReference.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2011 IBM Corporation and others.
+ * Copyright (c) 2011, 2013 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -28,8 +28,8 @@
try {
c.fail(Coordination.ORPHANED);
}
- catch (Throwable t) {
- c.getLogService().log(LogService.LOG_ERROR, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), t);
+ catch (Exception e) {
+ c.getLogService().log(LogService.LOG_WARNING, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), e);
}
finally {
try {
@@ -39,10 +39,10 @@
// This is expected since we already failed the coordination...
if (!Coordination.ORPHANED.equals(e.getCause()))
// ...but only if the cause is ORPHANED.
- c.getLogService().log(LogService.LOG_ERROR, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), e);
+ c.getLogService().log(LogService.LOG_DEBUG, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), e);
}
- catch (Throwable t) {
- c.getLogService().log(LogService.LOG_ERROR, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), t);
+ catch (Exception e) {
+ c.getLogService().log(LogService.LOG_WARNING, NLS.bind(Messages.OrphanedCoordinationError, c.getName(), c.getId()), e);
}
}
}
diff --git a/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinatorImpl.java b/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinatorImpl.java
index ed3ebe3..1f2b5a6 100644
--- a/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinatorImpl.java
+++ b/bundles/org.eclipse.equinox.coordinator/src/org/eclipse/equinox/coordinator/CoordinatorImpl.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2010, 2011 IBM Corporation and others.
+ * Copyright (c) 2010, 2013 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
