Reorder String Equality Check in CountExpression
To avoid NullPointerExceptions , it is recommended to put string
literals in the left-hand-side of equals() or equalsIgnoreCase() when
checking for equality.
Change-Id: I23c24c9594ab2d22a020a355c33b9c85de296375
Signed-off-by: Matthias Webhofer <matthias.webhofer@splendit.at>
diff --git a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/CountExpression.java b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/CountExpression.java
index c0b24aa..7aaaa5b 100644
--- a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/CountExpression.java
+++ b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/CountExpression.java
@@ -64,13 +64,13 @@
private void initializeSize(String size) {
if (size == null)
size= "*"; //$NON-NLS-1$
- if (size.equals("*")) //$NON-NLS-1$
+ if ("*".equals(size)) //$NON-NLS-1$
fMode= ANY_NUMBER;
- else if (size.equals("?")) //$NON-NLS-1$
+ else if ("?".equals(size)) //$NON-NLS-1$
fMode= NONE_OR_ONE;
- else if (size.equals("!")) //$NON-NLS-1$
+ else if ("!".equals(size)) //$NON-NLS-1$
fMode= NONE;
- else if (size.equals("+")) //$NON-NLS-1$
+ else if ("+".equals(size)) //$NON-NLS-1$
fMode= ONE_OR_MORE;
else if (size.charAt(0) == '-' && size.charAt(size.length() - 1) == ')') {
try {
