Bug 492970 - Prefer usage of Long.valueOf() over new Long in
org.eclipse.core.runtime
Change-Id: I7565cda7791ec595bd8ff6378ece63272809b754
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/preferences/legacy/PreferenceForwarder.java b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/preferences/legacy/PreferenceForwarder.java
index 1a9c7a1..66bcf80 100644
--- a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/preferences/legacy/PreferenceForwarder.java
+++ b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/preferences/legacy/PreferenceForwarder.java
@@ -170,7 +170,7 @@
else if (obj instanceof Float)
return new Float(defaults.getFloat(key, FLOAT_DEFAULT_DEFAULT));
else if (obj instanceof Long)
- return new Long(defaults.getLong(key, LONG_DEFAULT_DEFAULT));
+ return Long.valueOf(defaults.getLong(key, LONG_DEFAULT_DEFAULT));
else if (obj instanceof byte[])
return defaults.getByteArray(key, BYTE_ARRAY_DEFAULT_DEFAULT);
else if (obj instanceof Boolean)
@@ -600,8 +600,8 @@
final long longValue = getLong(name);
if (value == longValue)
return;
- Long oldValue = new Long(longValue);
- Long newValue = new Long(value);
+ Long oldValue = Long.valueOf(longValue);
+ Long newValue = Long.valueOf(value);
try {
notify = false;
if (getDefaultLong(name) == value)
diff --git a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/PerformanceStatsProcessor.java b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/PerformanceStatsProcessor.java
index c1312d7..540ddf6 100644
--- a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/PerformanceStatsProcessor.java
+++ b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/PerformanceStatsProcessor.java
@@ -76,7 +76,7 @@
*/
public static void failed(PerformanceStats stats, String pluginId, long elapsed) {
synchronized (instance) {
- instance.failures.put(stats, new Long(elapsed));
+ instance.failures.put(stats, Long.valueOf(elapsed));
}
instance.schedule(SCHEDULE_DELAY);
instance.logFailure(stats, pluginId, elapsed);
diff --git a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/PerformanceStats.java b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/PerformanceStats.java
index 62fd1b0..018a235 100644
--- a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/PerformanceStats.java
+++ b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/PerformanceStats.java
@@ -456,13 +456,13 @@
String option = InternalPlatform.getDefault().getOption(eventName);
if (option != null) {
try {
- value = new Long(option);
+ value = Long.valueOf(option);
} catch (NumberFormatException e) {
//invalid option, just ignore
}
}
if (value == null)
- value = new Long(Long.MAX_VALUE);
+ value = Long.valueOf(Long.MAX_VALUE);
thresholdMap.put(eventName, value);
}
return value.longValue();
diff --git a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java
index fa6d261..e1e3bc1 100644
--- a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java
+++ b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java
@@ -624,7 +624,7 @@
if (myBundle == null)
return ""; //$NON-NLS-1$
String name = myBundle.getSymbolicName();
- return name == null ? Long.toString(myBundle.getBundleId()) : name;
+ return name == null ? String.valueOf(myBundle.getBundleId()) : name;
}
/**
diff --git a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Preferences.java b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Preferences.java
index e771f21..789d1f4 100644
--- a/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Preferences.java
+++ b/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Preferences.java
@@ -1006,7 +1006,7 @@
// mark as dirty since value did really change
dirty = true;
// report property change if getValue now returns different value
- firePropertyChangeEvent(name, new Long(oldValue), new Long(value));
+ firePropertyChangeEvent(name, Long.valueOf(oldValue), Long.valueOf(value));
}
}
diff --git a/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/internal/di/InjectorImpl.java b/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/internal/di/InjectorImpl.java
index bfbee58..6b24e8c 100644
--- a/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/internal/di/InjectorImpl.java
+++ b/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/internal/di/InjectorImpl.java
@@ -92,7 +92,7 @@
final private static Character DEFAULT_CHAR = new Character((char) 0);
final private static Float DEFAULT_FLOAT = new Float(0.0f);
final private static Double DEFAULT_DOUBLE = new Double(0.0d);
- final private static Long DEFAULT_LONG = new Long(0L);
+ final private static Long DEFAULT_LONG = Long.valueOf(0L);
final private static Short DEFAULT_SHORT = new Short((short) 0);
final private static Byte DEFAULT_BYTE = new Byte((byte) 0);
