Apply "Primitive parsing" JDT cleanup to platform.runtime
A boxed primitive is created from a String, just to extract the unboxed
primitive value.It is more efficient to just call the static parseXXX
method.
Before:
int number = Integer.valueOf("42", 8);
new Double("42.42").doubleValue();
After:
int number = Integer.parseInt("42", 8);
Double.parseDouble("42.42");
Change-Id: I230422c07d27eab28ccb6dda58c1a5b4cdeb692b
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>diff --git a/bundles/org.eclipse.core.contenttype/src/org/eclipse/core/runtime/content/BinarySignatureDescriber.java b/bundles/org.eclipse.core.contenttype/src/org/eclipse/core/runtime/content/BinarySignatureDescriber.java
index f6f6427..b0fb253 100644
--- a/bundles/org.eclipse.core.contenttype/src/org/eclipse/core/runtime/content/BinarySignatureDescriber.java
+++ b/bundles/org.eclipse.core.contenttype/src/org/eclipse/core/runtime/content/BinarySignatureDescriber.java
@@ -98,7 +98,7 @@
if (parameters.containsKey(OFFSET))
offset = Integer.parseInt((String) parameters.get(OFFSET));
if (parameters.containsKey(REQUIRED))
- required = Boolean.valueOf((String) parameters.get(REQUIRED)).booleanValue();
+ required = Boolean.parseBoolean((String) parameters.get(REQUIRED));
}
} catch (NumberFormatException nfe) {
String message = NLS.bind(ContentMessages.content_badInitializationData, BinarySignatureDescriber.class.getName());
