Bug 519950: Improve Dark Theme so it works well with Menlo Font
The dark theme should not use bold font face massively. This is
not mac specific but surfaced when we switched the default
text font on mac from Monaco to Menlo. Monaco does only contain
a "regular" font face so all "bold" word were "regular". So this
issue was not visible on macOS. On other platforms this issue
should have been visible.
Also change some colors as some of them were too close the
keyword-color.
Change-Id: Icc3f73a9daf03c9544cc839ef50ed5f4b13910f7
Also-by: Till Brychcy <register.eclipse@brychcy.de>
Signed-off-by: Matthias Becker <ma.becker@sap.com>
diff --git a/org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css b/org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css
index 4abdf04..8123aba 100644
--- a/org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css
+++ b/org.eclipse.jdt.ui/css/e4-dark_jdt_syntaxhighlighting.css
@@ -27,8 +27,10 @@
'java_doc_keyword=154,140,124'
'java_doc_link=169,156,140'
'java_doc_tag=30,120,155'
- 'java_keyword=204,120,50'
- 'java_keyword_return=204,120,50'
+ 'java_keyword=204,108,29'
+ 'java_keyword_bold=false'
+ 'java_keyword_return=204,108,29'
+ 'java_keyword_return_bold=false'
'java_multi_line_comment=128,128,128'
'java_operator=230,230,250'
'java_single_line_comment=128,128,128'
@@ -39,20 +41,17 @@
'pf_coloring_comment=128,128,128'
'pf_coloring_key=217,232,247'
'pf_coloring_value=23,198,163'
- 'semanticHighlighting.abstractClass.bold=true'
'semanticHighlighting.abstractClass.color=62,171,230'
'semanticHighlighting.abstractClass.enabled=true'
'semanticHighlighting.abstractMethodInvocation.color=128,246,167'
'semanticHighlighting.abstractMethodInvocation.enabled=true'
- 'semanticHighlighting.annotation.bold=true'
- 'semanticHighlighting.annotation.color=255,147,147'
+ 'semanticHighlighting.annotation.color=160,160,160'
'semanticHighlighting.annotation.enabled=true'
'semanticHighlighting.annotation.italic=true'
'semanticHighlighting.annotationElementReference.color=235,75,100'
'semanticHighlighting.annotationElementReference.enabled=true'
'semanticHighlighting.class.color=18,144,195'
'semanticHighlighting.class.enabled=true'
- 'semanticHighlighting.class.bold=true'
'semanticHighlighting.deprecatedMember.color=171,31,54'
'semanticHighlighting.deprecatedMember.enabled=true'
'semanticHighlighting.deprecatedMember.underline=false'
@@ -66,14 +65,16 @@
'semanticHighlighting.inheritedMethodInvocation.enabled=true'
'semanticHighlighting.interface.color=128,242,246'
'semanticHighlighting.interface.enabled=true'
- 'semanticHighlighting.localVariable.color=255,191,38'
+ 'semanticHighlighting.localVariable.color=243,236,121'
'semanticHighlighting.localVariable.enabled=true'
- 'semanticHighlighting.localVariableDeclaration.color=237,127,72'
+ 'semanticHighlighting.localVariableDeclaration.color=242,242,0'
'semanticHighlighting.localVariableDeclaration.enabled=true'
+ 'semanticHighlighting.localVariableDeclaration.bold=false'
'semanticHighlighting.method.color=167,236,33'
'semanticHighlighting.method.enabled=true'
'semanticHighlighting.methodDeclarationName.color=30,181,64'
'semanticHighlighting.methodDeclarationName.enabled=true'
+ 'semanticHighlighting.methodDeclarationName.bold=false'
'semanticHighlighting.number.color=104,151,187'
'semanticHighlighting.number.enabled=true'
'semanticHighlighting.parameterVariable.color=121,171,255'
@@ -84,10 +85,11 @@
'semanticHighlighting.staticFinalField.enabled=true'
'semanticHighlighting.staticMethodInvocation.color=150,236,63'
'semanticHighlighting.staticMethodInvocation.enabled=true'
- 'semanticHighlighting.typeArgument.color=215,131,127'
+ 'semanticHighlighting.typeArgument.color=177,102,218'
'semanticHighlighting.typeArgument.enabled=true'
'semanticHighlighting.typeParameter.color=191,164,164'
'semanticHighlighting.typeParameter.enabled=true'
+ 'semanticHighlighting.typeParameter.bold=false'
'sourceHoverBackgroundColor=68,68,68'
}
