Using indexOf char instead of indexOf String in jdt.ui
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a
performance related discussion
Change-Id: Ib1aeab169e5443d4b8279c9629e7fe2806fd9f1d
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java
index e21a769..c7e2a4e 100644
--- a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java
+++ b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java
@@ -508,7 +508,7 @@
typeName= expressionBinding.getName();
if (typeName.length() == 0)
return Collections.emptyList();
- int typeParamStart= typeName.indexOf("<"); //$NON-NLS-1$
+ int typeParamStart= typeName.indexOf('<');
if (typeParamStart != -1)
typeName= typeName.substring(0, typeParamStart);
String[] proposals= StubUtility.getLocalNameSuggestions(fSourceCU.getJavaProject(), typeName, expressionBinding.getDimensions(), excluded);
diff --git a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java
index 877be17..1b8e163 100644
--- a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java
+++ b/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java
@@ -366,7 +366,7 @@
}
private void computeRenameTypeRefactoring() throws CoreException{
- if (getSimpleCUName().indexOf(".") != -1) { //$NON-NLS-1$
+ if (getSimpleCUName().indexOf('.') != -1) {
fRenameTypeProcessor= null;
fWillRenameType= false;
return;
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/PackagesViewLabelProvider.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/PackagesViewLabelProvider.java
index a9a618b..1a36751 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/PackagesViewLabelProvider.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/browsing/PackagesViewLabelProvider.java
@@ -162,7 +162,7 @@
private String calculateName(IPackageFragment fragment) {
String name= fragment.getElementName();
- if (name.indexOf(".") != -1) //$NON-NLS-1$
+ if (name.indexOf('.') != -1)
name= name.substring(name.lastIndexOf(".") + 1); //$NON-NLS-1$
return name;
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java
index 3102ea9..5e13f4b 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java
@@ -427,7 +427,7 @@
String dPath;
String ePath;
- if (relPath.indexOf("/") >= 0) { //$NON-NLS-1$
+ if (relPath.indexOf('/') >= 0) {
String path= relPath.substring(1);
dPath= 'd' + path;
ePath= 'e' + path;
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilteredPreferenceTree.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilteredPreferenceTree.java
index c8a1fc4..9d591d3 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilteredPreferenceTree.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/FilteredPreferenceTree.java
@@ -436,7 +436,7 @@
fRefreshJob.cancel();
fRefreshJob.schedule(getRefreshJobDelay());
filterText= filterText.trim();
- int index= filterText.indexOf("~"); //$NON-NLS-1$
+ int index= filterText.indexOf('~');
StringMatcher labelMatcher= null;
StringMatcher valueMatcher= null;
if (index == -1) {
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ChainCompletionTemplateBuilder.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ChainCompletionTemplateBuilder.java
index 1b2656f..eb91694 100644
--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ChainCompletionTemplateBuilder.java
+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ChainCompletionTemplateBuilder.java
@@ -100,7 +100,7 @@
for (final ITypeBinding parameter : method.getParameterTypes()) {
String tmp= String.valueOf(parameter.getName());
String parameterName= tmp.substring(0, 1).toLowerCase() + tmp.substring(1);
- int index= parameterName.indexOf("<"); //$NON-NLS-1$
+ int index= parameterName.indexOf('<');
if (index != -1) {
parameterName= parameterName.substring(0, index);
}
