Give warning for no auto module <= Java8 projects too Bug 525660 -
Automatic-Module-Name header needed for Java 9
Change-Id: Ibd6a26a0336d9d94b0bdfd0fa556824b044bb8c0
Signed-off-by: Vikas Chandra <Vikas.Chandra@in.ibm.com>
diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BundleErrorReporter.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BundleErrorReporter.java
index 500922b..fce81c4 100644
--- a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BundleErrorReporter.java
+++ b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BundleErrorReporter.java
@@ -106,29 +106,7 @@
}
- public static boolean is9OrHigher(IJavaProject project) {
- return is9OrHigher(getSourceCompliance(project));
- }
- private static String getSourceCompliance(IJavaProject project) {
- return project != null ? project.getOption(JavaCore.COMPILER_SOURCE, true) : JavaCore.getOption(JavaCore.COMPILER_SOURCE);
- }
- public static boolean is9OrHigher(String compliance) {
- return !isVersionLessThan(compliance, JavaCore.VERSION_9);
- }
-
- public static boolean isVersionLessThan(String version1, String version2) {
- if (JavaCore.VERSION_CLDC_1_1.equals(version1)) {
- version1= JavaCore.VERSION_1_1 + 'a';
- }
- if (JavaCore.VERSION_CLDC_1_1.equals(version2)) {
- version2= JavaCore.VERSION_1_1 + 'a';
- }
- return version1.compareTo(version2) < 0;
- }
private void validateAutomaticModuleName() {
- IJavaProject jp = JavaCore.create(fProject);
- if ( BundleErrorReporter.is9OrHigher(jp) == false)
- return;
int compilerFlag = CompilerFlags.getFlag(fProject, CompilerFlags.P_NO_AUTOMATIC_MODULE);
if( compilerFlag == CompilerFlags.IGNORE)
return;
