Bug 542432 - [Product Editor] add new features without version
The editor no longer inserts the (qualified) version for new features by
default since that's the typical use-case.
Change-Id: I588e568e98fe59cd0b6933577d6a3b2e2e3035a4
Signed-off-by: Julian Honnen <julian.honnen@vector.com>
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/FeatureSection.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/FeatureSection.java
index 5ffea64..0821a77 100644
--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/FeatureSection.java
+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/FeatureSection.java
@@ -214,16 +214,16 @@
dialog.create();
SWTUtil.setDialogSize(dialog, 400, 500);
if (dialog.open() == Window.OK) {
- addFeature(wizard.getFeatureId(), wizard.getFeatureVersion());
+ addFeature(wizard.getFeatureId());
}
}
- private void addFeature(String id, String version) {
+ private void addFeature(String id) {
IProduct product = getProduct();
IProductModelFactory factory = product.getModel().getFactory();
IProductFeature feature = factory.createFeature();
feature.setId(id);
- feature.setVersion(version);
+ feature.setVersion(""); //$NON-NLS-1$
feature.setRootInstallMode(true);
product.addFeatures(new IProductFeature[] { feature });
}
@@ -352,7 +352,7 @@
Object[] models = dialog.getResult();
for (Object model : models) {
IFeature feature = ((IFeatureModel) model).getFeature();
- addFeature(feature.getId(), feature.getVersion());
+ addFeature(feature.getId());
}
}
}
@@ -372,7 +372,7 @@
for (String id : requiredFeatures) {
// Do not add features that already exist
if (!getProduct().containsFeature(id)) {
- addFeature(id, ""); //$NON-NLS-1$
+ addFeature(id);
}
}
}
