Bug 367355 - [preferences] [console] Error message header is not
reliably showing the status of the page
Change-Id: I0bebdfedef1038ff1115fd859893337d9855c531
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java
index 7844424..881290b 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2000, 2018 IBM Corporation and others.
+ * Copyright (c) 2000, 2019 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -226,10 +226,7 @@
}
protected boolean canClearErrorMessage() {
- if (fWidthEditor.isValid() && fBufferSizeEditor.isValid()) {
- return true;
- }
- return false;
+ return fWidthEditor.isValid() && fBufferSizeEditor.isValid() && fTabSizeEditor.isValid();
}
/**
@@ -249,6 +246,9 @@
if (fBufferSizeEditor != null && event.getSource() != fBufferSizeEditor) {
fBufferSizeEditor.refreshValidState();
}
+ if (fTabSizeEditor != null && event.getSource() != fTabSizeEditor) {
+ fTabSizeEditor.refreshValidState();
+ }
checkState();
} else {
super.propertyChange(event);
