Bug 558316 - [Javadoc] Fix warnings in platform.resources

Fix syntax warnings aka missing description on @param, etc. Only Javadoc
changes. Should fix all remaining errors and warnings from
platform Javadoc build with -Xdoclint:reference,html,syntax.

Change-Id: Ic3182fc5b78d6af19062f732171244a79100b2f8
Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
diff --git a/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/FileCache.java b/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/FileCache.java
index a8a4e44..dff06a1 100644
--- a/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/FileCache.java
+++ b/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/FileCache.java
@@ -50,7 +50,7 @@
 	 * Public accessor to obtain the singleton file cache instance,
 	 * creating the cache lazily if necessary.
 	 * @return The file cache instance
-	 * @throws CoreException
+	 * @throws CoreException If the file cache could not be created
 	 */
 	public static FileCache getCache() throws CoreException {
 		synchronized (creationLock) {
@@ -76,10 +76,11 @@
 
 	/**
 	 * Implements {@link FileStore#toLocalFile(int, IProgressMonitor)}
-	 * @param source 
-	 * @param monitor
+	 * @param source source data to cache on disk
+	 * @param monitor 
+	 *            monitor to indicate progress and receive cancellation
 	 * @return The cached file
-	 * @throws CoreException
+	 * @throws CoreException on errors using the source filestore or writing the cache file
 	 */
 	public java.io.File cache(IFileStore source, IProgressMonitor monitor) throws CoreException {
 		try {
diff --git a/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/InternalFileSystemCore.java b/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/InternalFileSystemCore.java
index 1c1a4e5..e989ad1 100644
--- a/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/InternalFileSystemCore.java
+++ b/bundles/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/InternalFileSystemCore.java
@@ -53,11 +53,11 @@
 	}
 
 	/**
-	 * Implements the method EFS#getFileSystem(String)
+	 * Implements the method {@link EFS#getFileSystem(String)}
 	 * 
 	 * @param scheme The URI scheme of the file system
 	 * @return The file system
-	 * @throws CoreException
+	 * @throws CoreException on filesystem related errors
 	 */
 	public IFileSystem getFileSystem(String scheme) throws CoreException {
 		if (scheme == null)
@@ -83,7 +83,7 @@
 	}
 
 	/**
-	 * Implements the method EFS#getLocalFileSystem()
+	 * Implements the method {@link EFS#getLocalFileSystem()}
 	 * 
 	 * @return The local file system
 	 */
@@ -97,11 +97,11 @@
 	}
 
 	/**
-	 * Implements the method EFS#getStore(URI)
+	 * Implements the method {@link EFS#getStore(URI)}
 	 * 
 	 * @param uri The URI of the store to retrieve
 	 * @return The file store corresponding to the given URI
-	 * @throws CoreException
+	 * @throws CoreException on filesystem related errors or missing URI scheme
 	 */
 	public IFileStore getStore(URI uri) throws CoreException {
 		final String scheme = uri.getScheme();
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildCommand.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildCommand.java
index a20f463..c0d426c 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildCommand.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildCommand.java
@@ -165,10 +165,11 @@
 	}
 
 	/**
-	 * Return the {@link IncrementalProjectBuilder} for the {@link IBuildConfiguration}
-	 * If this builder is configuration agnostic, the same {@link IncrementalProjectBuilder} is
-	 * returned for all configurations.
-	 * @param config
+	 * Return the {@link IncrementalProjectBuilder} for the
+	 * {@link IBuildConfiguration} If this builder is configuration agnostic, the
+	 * same {@link IncrementalProjectBuilder} is returned for all configurations.
+	 *
+	 * @param config the config to get a builder for
 	 * @return {@link IncrementalProjectBuilder} corresponding to config
 	 */
 	public IncrementalProjectBuilder getBuilder(IBuildConfiguration config) {
@@ -225,7 +226,10 @@
 
 	/**
 	 * Set the IncrementalProjectBuilder(s) for this command
-	 * @param value
+	 *
+	 * @param value a single {@link IncrementalProjectBuilder} or a {@link Map} of
+	 *              {@link IncrementalProjectBuilder} indexed by
+	 *              {@link IBuildConfiguration}
 	 */
 	@SuppressWarnings("unchecked")
 	public void setBuilders(Object value) {
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildManager.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildManager.java
index f5177df..ab9bf0d 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildManager.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/BuildManager.java
@@ -402,7 +402,6 @@
 	/**
 	 * Runs all builders on all the given project configs, in the order that
 	 * they are given.
-	 * @param buildJobGroup
 	 * @return A status indicating if the build succeeded or failed
 	 */
 	public IStatus buildParallel(Digraph<IBuildConfiguration> configs, IBuildConfiguration[] requestedConfigs, int trigger, JobGroup buildJobGroup, IProgressMonitor monitor) {
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/Bucket.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/Bucket.java
index 8ff451a..a7c975a 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/Bucket.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/Bucket.java
@@ -120,15 +120,19 @@
 		public final static int RETURN = 2;
 
 		/**
-		 * Called after the bucket has been visited (and saved).
-		 * @throws CoreException
+		 * Called after the bucket has been visited and saved.
+		 *
+		 * @throws CoreException allows implementation to throw on error
 		 */
 		public void afterSaving(Bucket bucket) throws CoreException {
 			// empty implementation, subclasses to override
 		}
 
 		/**
-		 * @throws CoreException
+		 * Called after the bucket has been visited but before saved.
+		 *
+		 * @throws CoreException allows implementation to throw on error. Throwing an
+		 *                       exception prevents saving.
 		 */
 		public void beforeSaving(Bucket bucket) throws CoreException {
 			// empty implementation, subclasses to override
@@ -169,12 +173,14 @@
 	}
 
 	/**
-	 * Applies the given visitor to this bucket index.
-	 * @param visitor
-	 * @param filter
-	 * @param depth the number of trailing segments that can differ from the filter
+	 * Applies the given visitor to this bucket index and save changes.
+	 *
+	 * @param visitor the processor for the bucket entries
+	 * @param filter  a filter to skip bucket entries
+	 * @param depth   the number of trailing segments that can differ from the
+	 *                filter
 	 * @return one of STOP, RETURN or CONTINUE constants
-	 * @exception CoreException
+	 * @exception CoreException thrown by the visitor or from a failed save
 	 */
 	public final int accept(Visitor visitor, IPath filter, int depth) throws CoreException {
 		if (entries.isEmpty())
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/BucketTree.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/BucketTree.java
index 12b584e..2b4b2f6 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/BucketTree.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/BucketTree.java
@@ -55,9 +55,13 @@
 
 	/**
 	 * From a starting point in the tree, visit all nodes under it.
-	 * @param visitor
-	 * @param base
-	 * @param depth
+	 * 
+	 * @param visitor the processor for the bucket entries
+	 * @param base    the base path to start the tree at
+	 * @param depth   the max depth to decent the tree
+	 *
+	 * @exception CoreException thrown by the visitor or failure to load/save the
+	 *                          bucket
 	 */
 	public void accept(Bucket.Visitor visitor, IPath base, int depth) throws CoreException {
 		if (Path.ROOT.equals(base)) {
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/FileSystemResourceManager.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/FileSystemResourceManager.java
index f034e98..aef0071 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/FileSystemResourceManager.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/FileSystemResourceManager.java
@@ -525,8 +525,9 @@
 	}
 
 	/**
-	 * Never returns null
-	 * @param target
+	 * Never returns null.
+	 *
+	 * @param target the resource to get a store for
 	 * @return The file store for this resource
 	 */
 	public IFileStore getStore(IResource target) {
@@ -1039,9 +1040,10 @@
 
 	/**
 	 * The storage location for a resource has changed; update the location.
-	 * @param target
-	 * @param info
-	 * @param location
+	 *
+	 * @param target   the changed resource
+	 * @param info     the resource info to update
+	 * @param location the new storage location
 	 */
 	public void setLocation(IResource target, ResourceInfo info, URI location) {
 		FileStoreRoot oldRoot = info.getFileStoreRoot();
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/UnifiedTree.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/UnifiedTree.java
index 9ff5bc6..89b024d 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/UnifiedTree.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/localstore/UnifiedTree.java
@@ -83,11 +83,12 @@
 	}
 
 	/**
-	 * Pass in a a root for the tree, a file tree containing all of the entries for this
-	 * tree and a flag indicating whether the UnifiedTree should consult the fileTree where
-	 * possible for entries
-	 * @param root
-	 * @param fileTree
+	 * Pass in a a root for the tree, a file tree containing all of the entries for
+	 * this tree and a flag indicating whether the UnifiedTree should consult the
+	 * fileTree where possible for entries
+	 *
+	 * @param root     root of the tree. Must be file or folder.
+	 * @param fileTree an {@link IFileTree} which is used to build the unified tree
 	 */
 	public UnifiedTree(IResource root, IFileTree fileTree) {
 		this(root);
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/IPropertyManager.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/IPropertyManager.java
index fe0ac84..1c28979 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/IPropertyManager.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/IPropertyManager.java
@@ -24,7 +24,6 @@
 	 * Closes the property store for a resource
 	 *
 	 * @param target The resource to close the property store for
-	 * @exception CoreException
 	 */
 	void closePropertyStore(IResource target) throws CoreException;
 
@@ -39,9 +38,9 @@
 	 * <p>
 	 * The subtree under the given resource is traversed to the supplied depth.
 	 * </p>
-	 * @param target
-	 * @param depth
-	 * @exception CoreException
+	 * 
+	 * @param target the resource(tree) to delete properties from
+	 * @param depth  the max depth to delete properties from the resource(tree)
 	 */
 	void deleteProperties(IResource target, int depth) throws CoreException;
 
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/PropertyBucket.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/PropertyBucket.java
index 1ff6d97..707465b 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/PropertyBucket.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/properties/PropertyBucket.java
@@ -32,7 +32,8 @@
 		};
 		private static final String[][] EMPTY_DATA = new String[0][];
 		/**
-		 * value is a String[][] of {{propertyKey.qualifier, propertyKey.localName, propertyValue}}
+		 * value is an array of qualified-key value pairs String[][] of
+		 * {{propertyKey.qualifier, propertyKey.localName, propertyValue}}
 		 */
 		private String[][] value;
 
@@ -130,8 +131,9 @@
 		}
 
 		/**
-		 * @param path
-		 * @param value is a String[][] {{propertyKey, propertyValue}}
+		 * @param path  a path to identify this property entry
+		 * @param value an array of qualified-key value pairs
+		 *              (<code>String[][] {{propertyKey.qualifier, propertyKey.localName, propertyValue}}</code>)
 		 */
 		protected PropertyEntry(IPath path, String[][] value) {
 			super(path);
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/filtermatchers/AbstractFileInfoMatcher.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/filtermatchers/AbstractFileInfoMatcher.java
index 15ab7af..de8958f 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/filtermatchers/AbstractFileInfoMatcher.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/filtermatchers/AbstractFileInfoMatcher.java
@@ -44,8 +44,9 @@
 
 	/**
 	 * Sets initialization data for this matcher.
-	 * @param project
-	 * @param arguments
+	 *
+	 * @param project   project this matcher works on
+	 * @param arguments matcher specific initialization argument
 	 * @throws CoreException if initialization failed
 	 */
 	public abstract void initialize(IProject project, Object arguments) throws CoreException;
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/IModelProviderDescriptor.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/IModelProviderDescriptor.java
index 4e579ea..b4c03cd 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/IModelProviderDescriptor.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/IModelProviderDescriptor.java
@@ -85,7 +85,7 @@
 	 * @param traversals the traversals being tested
 	 * @return the subset of these traversals that overlap with the resources
 	 * that match this descriptor
-	 * @throws CoreException
+	 * @throws CoreException in case of error; depends on actual implementation
 	 */
 	ResourceTraversal[] getMatchingTraversals(ResourceTraversal[] traversals) throws CoreException;
 
diff --git a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/ModelProvider.java b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/ModelProvider.java
index 2865b15..b7c5f8d 100644
--- a/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/ModelProvider.java
+++ b/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/mapping/ModelProvider.java
@@ -113,7 +113,7 @@
 	 * @param monitor a progress monitor, or <code>null</code> if progress
 	 *     reporting is not desired
 	 * @return the resource mappings that cover the given resource.
-	 * @exception CoreException
+	 * @exception CoreException in case of error; depends on actual implementation
 	 */
 	public ResourceMapping[] getMappings(IResource resource, ResourceMappingContext context, IProgressMonitor monitor) throws CoreException {
 		return new ResourceMapping[0];
@@ -133,7 +133,7 @@
 	 * @param monitor a progress monitor, or <code>null</code> if progress
 	 *     reporting is not desired
 	 * @return the set of mappings that cover the given resources
-	 * @exception CoreException
+	 * @exception CoreException in case of error; depends on actual implementation
 	 */
 	public ResourceMapping[] getMappings(IResource[] resources, ResourceMappingContext context, IProgressMonitor monitor) throws CoreException {
 		Set<ResourceMapping> mappings = new HashSet<>();
@@ -186,7 +186,7 @@
 	 * @param monitor a progress monitor, or <code>null</code> if progress
 	 *     reporting is not desired
 	 * @return a set of traversals that cover the given mappings
-	 * @exception CoreException
+	 * @exception CoreException in case of error; depends on actual implementation
 	 */
 	public ResourceTraversal[] getTraversals(ResourceMapping[] mappings, ResourceMappingContext context, IProgressMonitor monitor) throws CoreException {
 		SubMonitor subMonitor = SubMonitor.convert(monitor, mappings.length);
diff --git a/bundles/org.eclipse.core.tools.resources/src/org/eclipse/core/tools/resources/ResourceContentProvider.java b/bundles/org.eclipse.core.tools.resources/src/org/eclipse/core/tools/resources/ResourceContentProvider.java
index e142cb9..b0f93e3 100644
--- a/bundles/org.eclipse.core.tools.resources/src/org/eclipse/core/tools/resources/ResourceContentProvider.java
+++ b/bundles/org.eclipse.core.tools.resources/src/org/eclipse/core/tools/resources/ResourceContentProvider.java
@@ -264,7 +264,10 @@
 	 * 
 	 * @param markerNode the marker's node
 	 * @param marker the marker object
-	 * @throws CoreException 
+	 * @throws CoreException if this method fails. Reasons include:
+	 * <ul>
+	 * <li>This marker does not exist.</li>
+	 * </ul>
 	 */
 	protected void extractMarkerAttributes(TreeContentProviderNode markerNode, IMarker marker) throws CoreException {
 
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/CharsetTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/CharsetTest.java
index 7dd7df0..17734b8 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/CharsetTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/CharsetTest.java
@@ -419,7 +419,6 @@
 	 * Test for getting charset on an IFile:
 	 * #getContentDescription() checks file sync state(), always returning the
 	 * correct content description, whereas getCharset() uses the cached charset if available.
-	 * @throws Exception
 	 */
 	public void testBug186984() throws Exception {
 		getResourcesPreferences().putBoolean(ResourcesPlugin.PREF_LIGHTWEIGHT_AUTO_REFRESH, false);
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/IResourceTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/IResourceTest.java
index db2f091..11510ba 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/IResourceTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/IResourceTest.java
@@ -78,8 +78,11 @@
 	ResourceDeltaVerifier verifier;
 
 	/**
-	 * @return Set
+	 * Get all files and directories in given directory recursive.
+	 *
 	 * @param dir
+	 *            the directory to start with
+	 * @return set of files and directories in given directory and sub-directories
 	 */
 	static protected Set<File> getAllFilesForDirectory(File dir) {
 		Set<File> result = new HashSet<>(50);
@@ -97,8 +100,14 @@
 	}
 
 	/**
-	 * @return Set
-	 * @param resource IResource
+	 * Get all files and directories in given resource recursive.
+	 *
+	 * @param resource
+	 *            the resource to start with. Resource can be a file in which case
+	 *            the result will only contain the file.
+	 * @param considerUnsyncLocalFiles
+	 *            if <code>true</code> force reading from filesystem
+	 * @return set of files and directories under given resource
 	 */
 	static protected Set<File> getAllFilesForResource(IResource resource, boolean considerUnsyncLocalFiles) throws CoreException {
 		Set<File> result = new HashSet<>(50);
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/NatureTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/NatureTest.java
index 6c02b37..63680fb 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/NatureTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/NatureTest.java
@@ -47,7 +47,9 @@
 
 	/**
 	 * Constructor for NatureTest.
+	 *
 	 * @param name
+	 *            name of the TestCase
 	 */
 	public NatureTest(String name) {
 		super(name);
@@ -361,7 +363,6 @@
 	 * to check if natures value is cached properly.
 	 *
 	 * See Bug 338055.
-	 * @throws Exception
 	 */
 	public void testBug338055() throws Exception {
 		final boolean finished[] = new boolean[] {false};
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceTest.java
index 68198db..83d8c9d 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceTest.java
@@ -152,7 +152,9 @@
 
 	/**
 	 * Creates a new ResourceTest
-	 * @param name java.lang.String
+	 *
+	 * @param name
+	 *            name of the TestCase
 	 */
 	public ResourceTest(String name) {
 		super(name);
@@ -867,9 +869,11 @@
 	}
 
 	/**
-	 * Modifies the content of the given file in the file system by
-	 * appending an 'f'.
+	 * Modifies the content of the given file in the file system by appending an
+	 * 'f'.
+	 *
 	 * @param file
+	 *            the file system file to extend
 	 */
 	protected void modifyInFileSystem(IFile file) {
 		String m = getClassName() + ".modifyInFileSystem(IFile): ";
@@ -888,9 +892,10 @@
 	}
 
 	/**
-	 * Modifies the content of the given file in the workspace by
-	 * appending a 'w'.
+	 * Modifies the content of the given file in the workspace by appending a 'w'.
+	 *
 	 * @param file
+	 *            the workspace file to extend
 	 */
 	protected void modifyInWorkspace(IFile file) throws CoreException {
 		String newContent = readStringInWorkspace(file) + "w";
@@ -899,9 +904,10 @@
 	}
 
 	/**
-	 * Returns the content of the given file in the file system as a
-	 * byte array.
+	 * Returns the content of the given file in the file system as a byte array.
+	 *
 	 * @param file
+	 *            file system file to read
 	 */
 	protected byte[] readBytesInFileSystem(IFile file) {
 		String m = getClassName() + ".readBytesInFileSystem(IFile): ";
@@ -923,8 +929,10 @@
 	}
 
 	/**
-	 * Returns the content of the given file in the workspace as a
-	 * byte array.
+	 * Returns the content of the given file in the workspace as a byte array.
+	 *
+	 * @param file
+	 *            workspace file to read
 	 */
 	protected byte[] readBytesInWorkspace(IFile file) {
 		String m = getClassName() + ".readBytesInWorkspace(IFile): ";
@@ -940,18 +948,20 @@
 	}
 
 	/**
-	 * Returns the content of the given file in the file system as a
-	 * String (UTF8).
+	 * Returns the content of the given file in the file system as a String (UTF8).
+	 *
 	 * @param file
+	 *            file system file to read
 	 */
 	protected String readStringInFileSystem(IFile file) {
 		return new String(readBytesInFileSystem(file), StandardCharsets.UTF_8);
 	}
 
 	/**
-	 * Returns the content of the given file in the workspace as a
-	 * String (UTF8).
+	 * Returns the content of the given file in the workspace as a String (UTF8).
+	 *
 	 * @param file
+	 *            workspace file to read
 	 */
 	protected String readStringInWorkspace(IFile file) {
 		return new String(readBytesInWorkspace(file), StandardCharsets.UTF_8);
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceURLTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceURLTest.java
index e033036..fa0566b 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceURLTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/ResourceURLTest.java
@@ -135,7 +135,6 @@
 
 	/**
 	 * Tests decoding of normalized URLs containing spaces
-	 * @throws CoreException
 	 */
 	public void testSpaces() {
 		IProject project = getWorkspace().getRoot().getProject("My Project");
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceSessionTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceSessionTest.java
index dd1f970..e48c2c5 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceSessionTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceSessionTest.java
@@ -46,7 +46,9 @@
 
 	/**
 	 * Constructor for WorkspaceSessionTest.
+	 *
 	 * @param name
+	 *            name of the TestCase
 	 */
 	public WorkspaceSessionTest(String name) {
 		super(name);
diff --git a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceTest.java b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceTest.java
index 9cf51ce..17febd0 100644
--- a/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceTest.java
+++ b/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/WorkspaceTest.java
@@ -47,7 +47,6 @@
 	/**
 	 * All of the WorkspaceTests build on each other. This test must
 	 * be run last of all to clean up from all previous tests in this class.
-	 * @throws Exception
 	 */
 	public void doCleanup() throws Exception {
 		IPath location = getWorkspace().getRoot().getLocation().append("testProject");