Remove redundant modifiers from
org.eclipse.e4.core.services
Change-Id: I32563f0d4423293a97a40a5005cb53ba191a193d
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.ui.prefs b/bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.ui.prefs
index e16fbde..bb7407b 100644
--- a/bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.ui.prefs
+++ b/bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.ui.prefs
@@ -99,6 +99,7 @@
sp_cleanup.qualify_static_member_accesses_with_declaring_class=false
sp_cleanup.qualify_static_method_accesses_with_declaring_class=false
sp_cleanup.remove_private_constructors=true
+sp_cleanup.remove_redundant_modifiers=true
sp_cleanup.remove_redundant_type_arguments=false
sp_cleanup.remove_trailing_whitespaces=true
sp_cleanup.remove_trailing_whitespaces_all=true
diff --git a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactory.java b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactory.java
index 5b0392e..de86a26 100644
--- a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactory.java
+++ b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactory.java
@@ -17,10 +17,10 @@
// Change it into an utility method somewhere.
public interface IContributionFactory {
- public Object create(String uriString, IEclipseContext context);
+ Object create(String uriString, IEclipseContext context);
- public Object create(String uriString, IEclipseContext context, IEclipseContext staticContext);
+ Object create(String uriString, IEclipseContext context, IEclipseContext staticContext);
- public Bundle getBundle(String uriString);
+ Bundle getBundle(String uriString);
}
diff --git a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactorySpi.java b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactorySpi.java
index 52bdb64..f2fef7b 100644
--- a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactorySpi.java
+++ b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/contributions/IContributionFactorySpi.java
@@ -16,8 +16,8 @@
// TBD only used by Languages block, move it there?
public interface IContributionFactorySpi {
- public Object create(Bundle bundle, String className, IEclipseContext context);
+ Object create(Bundle bundle, String className, IEclipseContext context);
- public Object call(Object object, String methodName, IEclipseContext context,
+ Object call(Object object, String methodName, IEclipseContext context,
Object defaultValue);
}
diff --git a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/events/IEventBroker.java b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/events/IEventBroker.java
index 38b1128..4a5ca86 100644
--- a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/events/IEventBroker.java
+++ b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/events/IEventBroker.java
@@ -30,7 +30,7 @@
/**
* The name of the default event attribute used to pass data.
*/
- public String DATA = "org.eclipse.e4.data"; //$NON-NLS-1$
+ String DATA = "org.eclipse.e4.data"; //$NON-NLS-1$
/**
* Publish event synchronously (the method does not return until the event is processed).
@@ -46,7 +46,7 @@
* @return <code>true</code> if this operation was performed successfully; <code>false</code>
* otherwise
*/
- public boolean send(String topic, Object data);
+ boolean send(String topic, Object data);
/**
* Publish event asynchronously (this method returns immediately).
@@ -62,7 +62,7 @@
* @return <code>true</code> if this operation was performed successfully; <code>false</code>
* otherwise
*/
- public boolean post(String topic, Object data);
+ boolean post(String topic, Object data);
/**
* Subscribe for events on the given topic.
@@ -77,7 +77,7 @@
* @return <code>true</code> if this operation was performed successfully; <code>false</code>
* otherwise
*/
- public boolean subscribe(String topic, EventHandler eventHandler);
+ boolean subscribe(String topic, EventHandler eventHandler);
/**
* Subscribe for events on the given topic.
@@ -98,7 +98,7 @@
* @return <code>true</code> if this operation was performed successfully;
* <code>false</code> otherwise
*/
- public boolean subscribe(String topic, String filter, EventHandler eventHandler,
+ boolean subscribe(String topic, String filter, EventHandler eventHandler,
boolean headless);
/**
@@ -109,5 +109,5 @@
* @return <code>true</code> if this operation was performed successfully; <code>false</code>
* otherwise
*/
- public boolean unsubscribe(EventHandler eventHandler);
+ boolean unsubscribe(EventHandler eventHandler);
}
diff --git a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/log/ILoggerProvider.java b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/log/ILoggerProvider.java
index 27f2fce..e504f86 100644
--- a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/log/ILoggerProvider.java
+++ b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/log/ILoggerProvider.java
@@ -11,5 +11,5 @@
package org.eclipse.e4.core.services.log;
public interface ILoggerProvider {
- public Logger getClassLogger(Class<?> clazz);
+ Logger getClassLogger(Class<?> clazz);
}
diff --git a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/nls/IMessageFactoryService.java b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/nls/IMessageFactoryService.java
index b76328d..51feb87 100644
--- a/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/nls/IMessageFactoryService.java
+++ b/bundles/org.eclipse.e4.core.services/src/org/eclipse/e4/core/services/nls/IMessageFactoryService.java
@@ -35,6 +35,6 @@
* bundle with a given locale.
* @return An instance of the given messages class and {@link Locale}.
*/
- public <M> M getMessageInstance(final Locale locale, final Class<M> messages,
+ <M> M getMessageInstance(final Locale locale, final Class<M> messages,
ResourceBundleProvider provider);
}
