[dogfooding][cleanup] Use static inner class clean up for core.tools Using this cleanup brings: - It reviews the feature - For optimization: small memory usage reduction as the outer pointer is removed Change-Id: I64addfd5de09074b5999cbb15a70209be053d266 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java index 0ad0ae6..f48f665 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EclipsePreferencesView.java
@@ -94,7 +94,7 @@ } } - class ViewLabelProvider extends LabelProvider { + static class ViewLabelProvider extends LabelProvider { @Override public String getText(Object obj) {
diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java index 3fa664b..e03d6f8 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/EventsView.java
@@ -48,7 +48,7 @@ */ public class EventsView extends TableWithTotalView { - class EventsViewContentProvider implements ITreeContentProvider { + static class EventsViewContentProvider implements ITreeContentProvider { @Override public void dispose() { // do nothing @@ -83,7 +83,7 @@ /** * Class to display the labels for the stats view table. */ - class EventsViewLabelProvider extends LabelProvider implements ITableLabelProvider, IColorProvider { + static class EventsViewLabelProvider extends LabelProvider implements ITableLabelProvider, IColorProvider { @Override public Image getColumnImage(Object arg0, int arg1) {
diff --git a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java index 1e96285..92e6b85 100644 --- a/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java +++ b/bundles/org.eclipse.core.tools/src/org/eclipse/core/tools/runtime/PluginListView.java
@@ -36,7 +36,7 @@ /** * Class which provides the text labels for the view. */ - class PluginListLabelProvider extends LabelProvider implements ITableLabelProvider { + static class PluginListLabelProvider extends LabelProvider implements ITableLabelProvider { @Override public Image getColumnImage(Object arg0, int arg1) { return null;