commit | c303ad400fd9e948e7e06231566cf6515b8e923c | [log] [tgz] |
---|---|---|
author | Lars Vogel <Lars.Vogel@vogella.com> | Wed May 04 12:12:28 2016 +0200 |
committer | Lars Vogel <Lars.Vogel@vogella.com> | Tue May 17 05:25:25 2016 -0400 |
tree | 1841dc058d48ea27a391a3b94d0ccf66b2615b7e | |
parent | aa4a5d75fe79973a5c4876ac174936f8f1a9d6cc [diff] |
Bug 492969 - org.eclipse.e4.core.internal.tests.contexts.inject.GenericsListTest$TestNamedObject.combineIt() concatenates strings using + in a loop Change-Id: I24f1acbaab0686fb3ac35d1524792653cf05b6c9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/tests/org.eclipse.e4.core.tests/src/org/eclipse/e4/core/internal/tests/contexts/inject/GenericsListTest.java b/tests/org.eclipse.e4.core.tests/src/org/eclipse/e4/core/internal/tests/contexts/inject/GenericsListTest.java index 011ae34..7746818 100644 --- a/tests/org.eclipse.e4.core.tests/src/org/eclipse/e4/core/internal/tests/contexts/inject/GenericsListTest.java +++ b/tests/org.eclipse.e4.core.tests/src/org/eclipse/e4/core/internal/tests/contexts/inject/GenericsListTest.java
@@ -36,11 +36,11 @@ } public String combineIt() { - String result = ""; + StringBuilder stringBuilder = new StringBuilder(); for (String string : field) { - result += string; + stringBuilder.append(string); } - return result; + return stringBuilder.toString(); } }