| commit | a9c4e9040e2cab47934d347893289880763130b8 | [log] [tgz] |
|---|---|---|
| author | dbaeumer <dbaeumer> | Wed Dec 07 18:05:53 2005 +0000 |
| committer | dbaeumer <dbaeumer> | Wed Dec 07 18:05:53 2005 +0000 |
| tree | 35ead790abb0449108c2f79e0c428e8afc19d3f9 | |
| parent | bed8d3486a69a1e887f6d613611b5b133ccdc21b [diff] |
Updated Javadoc to show that for boolean text expressions the expected value has to be honored as well.
diff --git a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/PropertyTester.java b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/PropertyTester.java index b053100..d9fea40 100644 --- a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/PropertyTester.java +++ b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/PropertyTester.java
@@ -39,7 +39,9 @@ * public boolean test(Object receiver, String property, Object[] args, Object expectedValue) { * IPackageFragment fragement= (IPackageFragment)receiver; * if ("isDefaultPackage".equals(property)) { - * return fragement.isDefaultPackage(); + * return expectedValue == null + * ? fragement.isDefaultPackage() + * : fragement.isDefaultPackage() == ((Boolean)expectedValue).booleanValue(); * } * Assert.isTrue(false); * return false;
diff --git a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/package.html b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/package.html index 20c7ad3..b1a0ba4 100644 --- a/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/package.html +++ b/bundles/org.eclipse.core.expressions/src/org/eclipse/core/expressions/package.html
@@ -101,7 +101,9 @@ if (PROPERTY_MATCHES_PATTERN.equals(method)) { String fileName= resource.getName(); StringMatcher matcher= new StringMatcher((String)expectedValue, false, false); - return matcher.match(fileName); + return expectedValue == null + ? matcher.match(fileName) + : matcher.match(filename) == ((Boolean)expectedValue).booleanValue(); } else if (...) { } Assert.isTrue(false);