[dogfooding][cleanup] Use static inner class clean up for team code
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I85c3e8d93c8b567296c3a7a4a0133d6ce635dda3
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java
index 2cdc74a..c63db37 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/CompareAction.java
@@ -115,7 +115,7 @@
// see
// org.eclipse.compare.internal.ResourceCompareInput.SelectAncestorDialog
- private class SelectAncestorDialog extends MessageDialog {
+ private static class SelectAncestorDialog extends MessageDialog {
private IResource[] theResources;
IResource ancestorResource;
IResource leftResource;
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java
index 886b0e4..0923435 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/GenericHistoryView.java
@@ -216,7 +216,7 @@
}
}
- abstract class MenuCreator implements IMenuCreator {
+ abstract static class MenuCreator implements IMenuCreator {
private MenuManager menuManager;
@Override
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java
index 619e673..58e1c49 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/LocalHistoryPage.java
@@ -131,7 +131,7 @@
private IFileRevision currentSelection;
- private final class LocalHistoryContentProvider implements ITreeContentProvider {
+ private static final class LocalHistoryContentProvider implements ITreeContentProvider {
@Override
public Object[] getElements(Object inputElement) {
if (inputElement instanceof IFileHistory) {
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java
index ac10c04..c937070 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshModelParticipantJob.java
@@ -40,7 +40,7 @@
private IProgressMonitor group;
private int groupTicks;
- public class ChangeDescription implements IChangeDescription, IDiffChangeListener {
+ public static class ChangeDescription implements IChangeDescription, IDiffChangeListener {
Map<IPath, IDiff> changes = new HashMap<>();
@Override
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java
index b2e9c8e..d5d4424 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/RefreshParticipantJob.java
@@ -176,7 +176,7 @@
/**
* Notification for safely notifying listeners of refresh lifecycle.
*/
- private abstract class Notification implements ISafeRunnable {
+ private abstract static class Notification implements ISafeRunnable {
private IRefreshSubscriberListener listener;
@Override
public void handleException(Throwable exception) {
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java
index bc8dbaf..bcc9d7c 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/synchronize/SynchronizeModelUpdateHandler.java
@@ -78,7 +78,7 @@
/**
* Custom event for posting marker changes
*/
- class MarkerChangeEvent extends Event {
+ static class MarkerChangeEvent extends Event {
private final ISynchronizeModelElement[] elements;
public MarkerChangeEvent(ISynchronizeModelElement[] elements) {
super(MARKERS_CHANGED);
@@ -92,7 +92,7 @@
/**
* Custom event for posting busy state changes
*/
- class BusyStateChangeEvent extends Event {
+ static class BusyStateChangeEvent extends Event {
private final ISynchronizeModelElement element;
private final boolean isBusy;
@@ -112,7 +112,7 @@
/**
* Custom event for posting sync info set changes
*/
- class SyncInfoSetChangeEvent extends Event {
+ static class SyncInfoSetChangeEvent extends Event {
private final ISyncInfoSetChangeEvent event;
public SyncInfoSetChangeEvent(ISyncInfoSetChangeEvent event) {
super(SYNC_INFO_SET_CHANGED);
diff --git a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java
index 0a07755..d79165e 100644
--- a/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java
+++ b/bundles/org.eclipse.team.ui/src/org/eclipse/team/ui/synchronize/SynchronizePageActionGroup.java
@@ -82,7 +82,7 @@
* page. Selection changed events are sent out when the model roots change
* or their visible children change
*/
- private class VisibleRootsSelectionProvider extends SynchronizePageActionGroup implements ISelectionProvider {
+ private static class VisibleRootsSelectionProvider extends SynchronizePageActionGroup implements ISelectionProvider {
private ListenerList<ISelectionChangedListener> selectionChangedListeners = new ListenerList<>(ListenerList.IDENTITY);
private ISelection selection;
