Bug 539439 - checkbox label not clickable
Add <label for=""/> to enable clicks on the label as well.
Change-Id: Ica4e9e4804cd146e069c0887d44496714522d99d
Signed-off-by: Sergey Fukanchik <fukanchik@gmail.com>
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java
index 6a7a334..997f59a 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java
@@ -73,7 +73,7 @@
// Use an IIntroAction url that points back to this class -
// particularly invoking run().
// This url is 'activated' using the onClick event.
- out.print("<div id=\""+id+"\"><input type=\"checkbox\" "+ //$NON-NLS-1$//$NON-NLS-2$
+ out.print("<div id=\""+id+"\"><input id=\"run-action-" + id + "\" type=\"checkbox\" "+ //$NON-NLS-1$//$NON-NLS-2$//$NON-NLS-3$
"onClick=window.location="+ //$NON-NLS-1$
"\"http://org.eclipse.ui.intro/runAction?"+ //$NON-NLS-1$
"pluginId=org.eclipse.ui.intro&"+ //$NON-NLS-1$
@@ -87,7 +87,7 @@
IWorkbenchPreferenceConstants.SHOW_INTRO, alwaysShowIntro);
}
- out.println("/>"+getText()+"</div>"); //$NON-NLS-1$//$NON-NLS-2$
+ out.println("/><label for=\"run-action-" + id + "\">"+getText()+"</label></div>"); //$NON-NLS-1$//$NON-NLS-2$//$NON-NLS-3$
}