[dogfooding][cleanup] Use static inner class clean up for
intro code
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I76ed30b7303b62bbdb2b7ce4476f1e7153b8abaa
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java b/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java
index 73b66c7..1715ef1 100644
--- a/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java
+++ b/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java
@@ -383,7 +383,7 @@
}
}
- class IntroTheme {
+ static class IntroTheme {
IConfigurationElement element;
Image previewImage;
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java
index d66c7e9..4666d60 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java
@@ -35,7 +35,7 @@
// IFrame is stored in history as a different object with the IFrameURL set.
// This way the model actually creates one page for every embedded Help
// Topic target but the navigation history updates the IFrame accordingly.
- class HistoryObject {
+ static class HistoryObject {
AbstractIntroPage page;
String iframeUrl;
String url;
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java
index 824b7c9..a1da253 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java
@@ -44,7 +44,7 @@
private IntroModelRoot model;
- private class TitleAndSummary {
+ private static class TitleAndSummary {
String title;
String summary;
}
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java
index 56bb898..3d0d044 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java
@@ -54,7 +54,7 @@
private Map<String, ContentProviderWrapper> contentProviders = new HashMap<>();
- class ContentProviderWrapper {
+ static class ContentProviderWrapper {
IIntroContentProvider provider;
AbstractIntroPage parentPage;
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java
index 683360d..d9ac57e 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java
@@ -75,7 +75,7 @@
}
}
- class RootPageLayout extends Layout {
+ static class RootPageLayout extends Layout {
// gap between link composite and description label.
private int VERTICAL_SPACING = 20;
