commit fa662230840fa92752a6efd6369873571465ea46
author Holger Voormann <eclipse@voormann.de> Wed Apr 21 20:05:07 2021 +0200
committer Wim Jongman <wim.jongman@remainsoftware.com> Wed Apr 21 14:43:30 2021 -0400
tree 4b7d2b4f1bfa9ea5dd6a894dd4d090c9e2a882af
parent 592b0249257361dd55763f5352a20fc1da6a7107

Bug 571831 - Modernized help UI: in a search link ' ' must not become +

Avoid accidentally turning spaces (' ') into plus signs ('+') in a
search link. For example, if you bookmark the search "Hello world" in
Infocenter mode, the bookmark should not trigger the search
"Hello+world".

Problem:
In an URL a space can be coded as ' ', '%20' or '+', but the JavaScript
function decodeURIComponent() decodes only '%20' and not '+'.
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent

Change-Id: I1a332710869d924cab7076ba7aa667a138c46a5f
Signed-off-by: Holger Voormann <eclipse@voormann.de>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/179611
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Wim Jongman <wim.jongman@remainsoftware.com>

org.eclipse.help.webapp/m/index.js

diff --git a/org.eclipse.help.webapp/m/index.js b/org.eclipse.help.webapp/m/index.js
index 3edb903..34e3c73 100644
--- a/org.eclipse.help.webapp/m/index.js
+++ b/org.eclipse.help.webapp/m/index.js
@@ -2681,7 +2681,7 @@
     function getParams(queryPart) {
         var params = {};
         queryPart.replace(/(?:^|&+)([^=&]+)=([^&]*)/gi,
-            function(_match, group1Param, group2Value) { params[group1Param] = decodeURIComponent(group2Value); });
+            function(_match, group1Param, group2Value) { params[group1Param] = decodeURIComponent(group2Value.replace(/\+/g, ' ')); });
         return params;
     }