| commit | 45ef4c3d7c3d9bd9bef9ea8af9b33903730dd612 | [log] [tgz] |
|---|---|---|
| author | Lars Vogel <Lars.Vogel@vogella.com> | Fri Jun 05 18:32:58 2020 +0200 |
| committer | Lars Vogel <Lars.Vogel@vogella.com> | Wed Jun 10 10:58:14 2020 -0400 |
| tree | e596f000ee704ebd3179c4d9ef9cd7bd49c65406 | |
| parent | 46dc044d233e7c0cb32d4cc0bec18a69aa511372 [diff] |
Bug 564117 - Using lazy logical operator Use lazy logical operator (&& and ||) as it is potentially faster. Change-Id: Iabb619d8e05257270241194abb44b280fb7279bb Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntBuildLogger.java b/ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntBuildLogger.java index a18ccd6..10dc159 100644 --- a/ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntBuildLogger.java +++ b/ant/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote/logger/RemoteAntBuildLogger.java
@@ -263,7 +263,7 @@ } private void processEvent(BuildEvent event) { - if (event.getTask() != null & !emacsMode) { + if (event.getTask() != null && !emacsMode) { try { marshalTaskMessage(event); }
diff --git a/ant/org.eclipse.ant.tests.ui/External Tools/org/eclipse/ant/tests/ui/externaltools/BuilderCoreUtilsTests.java b/ant/org.eclipse.ant.tests.ui/External Tools/org/eclipse/ant/tests/ui/externaltools/BuilderCoreUtilsTests.java index 9162ef7..6b264b6 100644 --- a/ant/org.eclipse.ant.tests.ui/External Tools/org/eclipse/ant/tests/ui/externaltools/BuilderCoreUtilsTests.java +++ b/ant/org.eclipse.ant.tests.ui/External Tools/org/eclipse/ant/tests/ui/externaltools/BuilderCoreUtilsTests.java
@@ -503,8 +503,7 @@ assertNotNull("The build kinds array cannot be null", array); //$NON-NLS-1$ boolean contains = true; for (int element : array) { - contains &= (element == IncrementalProjectBuilder.AUTO_BUILD) | (element == IncrementalProjectBuilder.CLEAN_BUILD) - | (element == IncrementalProjectBuilder.FULL_BUILD) | (element == IncrementalProjectBuilder.INCREMENTAL_BUILD); + contains &= (element == IncrementalProjectBuilder.AUTO_BUILD) || (element == IncrementalProjectBuilder.CLEAN_BUILD) || (element == IncrementalProjectBuilder.FULL_BUILD) || (element == IncrementalProjectBuilder.INCREMENTAL_BUILD); if (!contains) { break; }